Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused constant #34515

Merged
merged 1 commit into from
Jun 21, 2017
Merged

remove unused constant #34515

merged 1 commit into from
Jun 21, 2017

Conversation

jimengliu
Copy link

@jimengliu jimengliu commented Oct 11, 2016 •
edited by k8s-oncall

What this PR does / why we need it:

In flexvolume constant definitions, fix typo StatusFailure string to "Failure", not "Failed" at

kubernetes/pkg/volume/flexvolume/flexvolume_util.go

Line 45 in b359034

StatusFailure = "Failed"

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#34510

Special notes for your reviewer:
Simple string literal change, but hopefully will prevent future confusion for developers.

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line.

Regular contributors should join the org to skip this step.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 11, 2016
@jimengliu
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jimengliu
Copy link
Author

"@k8s-bot ok to test

@pmorie
Copy link
Member

pmorie commented Oct 22, 2016

@k8s-bot ok to test

@pmorie pmorie added sig/storage Categorizes an issue or PR as relevant to SIG Storage. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 22, 2016
@pmorie
Copy link
Member

pmorie commented Oct 22, 2016

@jimengliu sorry for the latency on the review.

@pmorie
Copy link
Member

pmorie commented Nov 3, 2016

I don't see that this constant is used at all -- am I missing something, @jimengliu?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 3, 2016
@jimengliu
Copy link
Author

@pmorie It is not used at this moment, but it does not mean it won't get used in future by someone. So the solution either is to remove it or change it, since it is indeed wrong.

@pmorie
Copy link
Member

pmorie commented Jan 11, 2017

@jimengliu I'd prefer to remove unused code over correcting problems that may exist with it. If you change this to delete it, I'll LGTM.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 11, 2017
@jimengliu
Copy link
Author

sure, updated the PR.

@thockin
Copy link
Member

thockin commented Feb 16, 2017

/lgtm

LGTM from the bulk LGTM tool

@thockin thockin self-assigned this Feb 16, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2017
@jimengliu
Copy link
Author

rebased

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: jimengliu, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 1, 2017
@thockin thockin changed the title fix typo StatusFailure string to Failure, not Failed remove unused constant Mar 2, 2017
@thockin
Copy link
Member

thockin commented Mar 2, 2017

@k8s-bot gce etcd3 e2e test this

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2017
@mikedanese
Copy link
Member

@k8s-bot gce etcd3 e2e test this

@grodrigues3 grodrigues3 added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2017
@pmorie
Copy link
Member

pmorie commented Apr 5, 2017

@k8s-bot node e2e test this

@pmorie
Copy link
Member

pmorie commented Apr 5, 2017

@k8s-bot non-cri e2e test this

@timothysc
Copy link
Member

@k8s-bot node e2e test this

@wojtek-t
Copy link
Member

@k8s-bot gce etcd3 e2e test this

@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@mtanino
Copy link

mtanino commented Jun 13, 2017

/retest

5 similar comments
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/retest

@spiffxp
Copy link
Member

spiffxp commented Jun 17, 2017

/retest

@spiffxp
Copy link
Member

spiffxp commented Jun 17, 2017

/retest

@dchen1107
Copy link
Member

/retest

@dchen1107
Copy link
Member

/retest

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 34515, 47236, 46694, 47819, 47792)

@k8s-github-robot k8s-github-robot merged commit 0a6d307 into kubernetes:master Jun 21, 2017
@k8s-ci-robot
Copy link
Contributor

@jimengliu: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e 5c53a90 link @k8s-bot gce etcd3 e2e test this
pull-kubernetes-e2e-gce-etcd3 5c53a90 link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmorie pmorie

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet