Pass whole PVC to provisioner plugins #34611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gluster provisioner is interested in pvc.Namespace and I don't want to add at as a new field in VolumeOptions - it would contain almost whole PVC. Let's pass direct reference to PVC instead and let the provisioner to pick information it is interested in.
jsafrane
added
sig/storage
k8s-github-robot
added
size/L
jsafrane
added
release-note-none
rootfs
approved these changes
Oct 12, 2016
| // Reclamation policy for a persistent volume | ||
| PersistentVolumeReclaimPolicy api.PersistentVolumeReclaimPolicy | ||
| // PV.Name of the appropriate PersistentVolume. Used to generate cloud | ||
| // volume name. | ||
| PVName string | ||
| // PVC.Name of the PersistentVolumeClaim; only set during dynamic provisioning. | ||
| PVCName string | ||
| // PVC is reference to the claim that lead to provisioning of a new PV. |
|
I see this, it is in my queue, but I can't get to it quite yet. |
|
Thanks @jsafrane . Patch lgtm. |
|
LGTM! |
|
LGTM |
thockin
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 20, 2016
Automatic merge from submit-queue Makeuse of PVC namespace when provisioning gluster volumes. Depends on #34611
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Automatic merge from submit-queue Pass whole PVC to provisioner plugins Gluster provisioner is interested in namespace of PVCs that are being provisioned and I don't want to add at as a new field in `volume.VolumeOptions` - it would contain almost whole PVC. Let's rework `VolumeOptions` and pass direct reference to PVC there instead of some "interesting" fields and let the provisioner to pick information it is interested in. There was lot of refactoring in volume plugins to apply this change (too many plugins), however the logic is simple and it's all the same in all plugins. @rootfs @humblec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gluster provisioner is interested in namespace of PVCs that are being provisioned and I don't want to add at as a new field in
volume.VolumeOptions- it would contain almost whole PVC.Let's rework
VolumeOptionsand pass direct reference to PVC there instead of some "interesting" fields and let the provisioner to pick information it is interested in.There was lot of refactoring in volume plugins to apply this change (too many plugins), however the logic is simple and it's all the same in all plugins.
@rootfs @humblec
This change is