Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodePort value in kubectl output #34922

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

zreigz
Copy link
Contributor

@zreigz zreigz commented Oct 17, 2016

This PR enhances kubectl output after the command execution: kubectl get svc.
It additionally shows the value of the NodePort.

This PR is a response for this issue: #34100


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line.

Regular contributors should join the org to skip this step.

@zreigz
Copy link
Contributor Author

zreigz commented Oct 17, 2016

cc @sebgoa @adohe

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Oct 17, 2016
@brendandburns brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Oct 20, 2016
@brendandburns
Copy link
Contributor

@k8s-bot ok to test

LGTM.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2016
@sebgoa
Copy link
Contributor

sebgoa commented Oct 20, 2016

thanks, +1 (note that usually nodeports are in the 30000's range )

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 10ebd65 into kubernetes:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants