test: wait for complete rollouts in WaitForDeploymentStatusValid #34942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
0xmichalis
added
release-note-none
mfojtik
suggested changes
Oct 17, 2016
| return true, nil | ||
|
|
||
| // When the deployment status and its underlying resources reach the desired state, we're done | ||
| if deployment.Status.Replicas == deployment.Spec.Replicas && |
There was a problem hiding this comment.
i thought we have helper method for this
There was a problem hiding this comment.
It's somewhere in the perma-failed PR i think:) I will refactor this once I get the API merged (so the impl will get its turn)
| return true, nil | ||
| } | ||
|
|
||
| reason = fmt.Sprintf("deployment status: %#v", deployment.Status) |
There was a problem hiding this comment.
you don't need this var, just Logf
There was a problem hiding this comment.
I need it in case we timeout. Will be printed instead of "timed out waiting for the condition".
|
LGTM |
0xmichalis
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kubernetes/deployment should fix #34816 once and forever
This change is