Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #35346 #35380

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Automated cherry pick of #35346 #35380

merged 1 commit into from
Oct 24, 2016

Conversation

bprashanth
Copy link
Contributor

@bprashanth bprashanth commented Oct 22, 2016 •
edited by k8s-oncall

Cherry pick of #35346 on release-1.4.
#35346: substitute gcloud regex with regexp

This change is Reviewable

@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 22, 2016
@bprashanth bprashanth added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 22, 2016
@bprashanth bprashanth added this to the v1.4 milestone Oct 22, 2016
@bprashanth bprashanth assigned ixdy and unassigned fejta Oct 22, 2016
@jessfraz jessfraz added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 24, 2016
@jessfraz jessfraz self-assigned this Oct 24, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@ixdy
Copy link
Member

ixdy commented Oct 24, 2016

LGTM

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 7943a6a. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 7943a6a. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 07a8c55 into kubernetes:release-1.4 Oct 24, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#35380 from bprashanth/automated-cherry-…
4316031 
…pick-of-#35346-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#35346

Cherry pick of kubernetes#35346 on release-1.4.

kubernetes#35346: substitute gcloud regex with regexp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jessfraz jessfraz

@ixdy ixdy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@bprashanth @k8s-github-robot @ixdy @k8s-ci-robot @k8s-cherrypick-bot @fejta @jessfraz @googlebot