Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Max' and 'MIn' don't seem to used anywhere, so I would suggest removing them #35487

Merged
merged 1 commit into from Nov 8, 2016
Merged

'Max' and 'MIn' don't seem to used anywhere, so I would suggest removing them #35487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions plugin/pkg/admission/limitranger/admission.go
View file
Open in desktop
Expand Up @@ -164,22 +164,6 @@ func NewLimitRanger(client clientset.Interface, actions LimitRangerActions) (adm
}, nil
}

// Min returns the lesser of its 2 arguments
func Min(a int64, b int64) int64 {
if a < b {
return a
}
return b
}

// Max returns the greater of its 2 arguments
func Max(a int64, b int64) int64 {
if a > b {
return a
}
return b
}

// defaultContainerResourceRequirements returns the default requirements for a container
// the requirement.Limits are taken from the LimitRange defaults (if specified)
// the requirement.Requests are taken from the LimitRange default request (if specified)
Expand Down