Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a consistent name ( GlusterFS instead of Gluster) in variables a… #35669

Merged

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Oct 27, 2016

Signed-off-by: Humble Chirammal hchiramm@redhat.com


This change is Reviewable

…nd error messages.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Oct 27, 2016
@rootfs
Copy link
Contributor

rootfs commented Oct 27, 2016

lgtm
@jsafrane ?

@jsafrane jsafrane added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Oct 31, 2016
@jsafrane
Copy link
Member

@k8s-bot ok to test

@jsafrane jsafrane added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 12b7782. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2016

@jsafrane @rootfs Can we retrigger the tests or push to merge queue again ? The failure looks irreleveant to this PR

W1031 01:52:08.710] E1031 01:52:08.709999   19844 cni.go:163] error updating cni config: No networks found in /etc/cni/net.d
W1031 01:52:08.710] W1031 01:52:08.710153   19844 iptables.go:143] Error checking iptables version, assuming version at least 1.4.11: executable file not found in $PATH
W1031 01:52:08.710] W1031 01:52:08.710301   19844 iptables.go:143] Error checking iptables version, assuming version at least 1.4.11: executable file not found in $PATH

@jsafrane
Copy link
Member

jsafrane commented Nov 1, 2016

@k8s-bot unit test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 12b7782. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@humblec
Copy link
Contributor Author

humblec commented Nov 1, 2016

Thanks @jsafranek..

hmm.. the GCE failed with below error, looks like a spurious one.

W1101 02:10:19.165] E1101 02:10:19.165124    1270 remote.go:205] Failed to configured firewall: command [ssh -i /home/jenkins/.ssh/google_compute_engine -o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR 104.197.206.3 -- sudo sh -c 'iptables -L INPUT | grep "Chain INPUT (policy DROP)"&&(iptables -C INPUT -w -p TCP -j ACCEPT || iptables -A INPUT -w -p TCP -j ACCEPT)&&(iptables -C INPUT -w -p UDP -j ACCEPT || iptables -A INPUT -w -p UDP -j ACCEPT)&&(iptables -C INPUT -w -p ICMP -j ACCEPT || iptables -A INPUT -w -p ICMP -j ACCEPT)'] failed with error: exit status 1 and output:

@jsafrane
Copy link
Member

jsafrane commented Nov 1, 2016

@k8s-bot node e2e test this

@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

Release-czar approved post-code freeze merge--This was LGTMed and in the merge-queue at code freeze time for 1.5. Adding 1.5 milestone to let it gets merged after code freeze.

@saad-ali saad-ali added this to the v1.5 milestone Nov 8, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit d87dfa2 into kubernetes:master Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants