Disable the test-owners verify step until the merge conflicts are resolved #36096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmmh
added
retest-not-required
release-note-none
|
I would suggest still running it and reporting the output, but not failing when it fails. |
…olved. Fixes kubernetes#35850. GitHub's merging doesn't support .gitattributes-- I verified this with support. There may be a workaround with line padding or making the bot do merges on its own, which is beneficial for custom merge conflict resolution in general.
rmmh
force-pushed
the
disable-verify-owners
branch
from
6637d00
to
57a152c
Compare
k8s-github-robot
added
the
size/XS
|
OK, changed. |
|
/lgtm |
k8s-github-robot
added
the
lgtm
|
Jenkins GCE Node e2e failed for commit 57a152c. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot node e2e test this |
|
Automatic merge from submit-queue |
dims
added a commit
to dims/kubernetes
that referenced
this pull request
Nov 11, 2016
Manual update to test_owners.csv, Add a update script that simply calls the python script Note that verify-test-owners.sh does not fail when things are out of whack (details in PR kubernetes#36096)
dims
added a commit
to dims/kubernetes
that referenced
this pull request
Nov 14, 2016
Manual update to test_owners.csv, Add a update script that simply calls the python script Note that verify-test-owners.sh does not fail when things are out of whack (details in PR kubernetes#36096)
dims
added a commit
to dims/kubernetes
that referenced
this pull request
Nov 16, 2016
Manual update to test_owners.csv, Add a update script that simply calls the python script Note that verify-test-owners.sh does not fail when things are out of whack (details in PR kubernetes#36096)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's causing more pain than it's preventing currently. There should be some simpler ways to fix this.
This change is