kubectl: enhancements for deployment progress deadline #36171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
0xmichalis
added
release-note-none
mengqiy
reviewed
Nov 4, 2016
| @@ -2161,6 +2161,13 @@ func (dd *DeploymentDescriber) Describe(namespace, name string, describerSetting | |||
| ru := d.Spec.Strategy.RollingUpdate | |||
| fmt.Fprintf(out, "RollingUpdateStrategy:\t%s max unavailable, %s max surge\n", ru.MaxUnavailable.String(), ru.MaxSurge.String()) | |||
| } | |||
| if len(d.Status.Conditions) > 0 { | |||
| fmt.Fprint(out, "Conditions:\n Type\tStatus\tReason\n") | |||
| fmt.Fprint(out, " ----\t------\t------\n") | |||
There was a problem hiding this comment.
I think we can use tabwriter here.
There was a problem hiding this comment.
All the rest of the describers are not using it atm and I don't want to introduce a bigger change in this PR just before the code freeze.
Changes: * add deployment conditions in the describer * abort 'rollout status' for deployments that have exceeded their progress deadline
|
LGTM |
0xmichalis
added
the
lgtm
|
Jenkins unit/integration failed for commit f97666e. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
progress deadline
Depends on #35691.
@kubernetes/kubectl @kubernetes/deployment
Fixes #31319
This change is