Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase quota-bytes for etcd in v3 mode #36240

Merged
merged 1 commit into from
Nov 6, 2016

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 4, 2016

Ref #20504


This change is Reviewable

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 4, 2016
@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2016
@wojtek-t wojtek-t modified the milestones: v1.4, v1.5 Nov 4, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2016
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 4, 2016

Fixed verify - reapplying label.

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 4, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit fc1a3c0cc674654c3ba14f53ec45e4dfeac3e0b1. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@xiang90
Copy link
Contributor

xiang90 commented Nov 4, 2016

4GB is really the dangerous line for etcd (see Chubby's or PaxosDB's limit? I know ZK or Consul wont handle this well). I hope people who run large clusters have good networking + disk... I might optimize this eventually, but do not expect that we can make this number 40GB. Just a reminder.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit ca99cbc. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit ca99cbc. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 4, 2016

but do not expect that we can make this number 40GB. Just a reminder.

@xiang90 - yes sure; That's completely fine.

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 4, 2016

Also - I would like to reduce this value in the future, but I've seen it happening in large clusters, to increasing it for now. I'm planning to understand this and decrease it in future releases.

@xiang90
Copy link
Contributor

xiang90 commented Nov 4, 2016

Also - I would like to reduce this value in the future, but I've seen it happening in large clusters, to increasing it for now. I'm planning to understand this and decrease it in future releases.

Awesome. I would love to help.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b7512d9 into kubernetes:master Nov 6, 2016
@wojtek-t wojtek-t deleted the quota_bytes_backend branch November 18, 2016 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants