Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options, kube-apiserver: clarify scheme on etcd endpoints #36321

Merged
merged 1 commit into from
Nov 8, 2016

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Nov 6, 2016

What this PR does / why we need it:

Fix typo in kube-apiserver flag.

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

None


This change is Reviewable

When etcd server uses TLS, the scheme should be https.
@k8s-ci-robot
Copy link
Contributor

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 6, 2016
@nikhiljindal
Copy link
Contributor

LGTM, thx!
I dont think we need a release note for this.

@nikhiljindal nikhiljindal added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 6, 2016
@gyuho
Copy link
Member Author

gyuho commented Nov 6, 2016

@nikhiljindal Agree. Just left release note empty. Thanks!

@saad-ali saad-ali added this to the v1.5 milestone Nov 8, 2016
@saad-ali
Copy link
Member

saad-ali commented Nov 8, 2016

Release-czar approved post-code freeze merge--This was LGTMed and in the merge-queue at code freeze time for 1.5. Adding 1.5 milestone to let it gets merged after code freeze.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9b32a5d into kubernetes:master Nov 8, 2016
@gyuho gyuho deleted the etcd-flag branch November 8, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants