Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federation: allow specification of dns zone by ID #36336

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Federation: allow specification of dns zone by ID #36336

merged 1 commit into from
Nov 17, 2016

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Nov 7, 2016 •
edited by k8s-oncall
Loading

If we have a public & private zone with the same name (which is common
on AWS), this means we can still create records. Also tighten up some
of the logic to allow for zones with duplicate names.

This change is Reviewable

@justinsb
Copy link
Member Author

justinsb commented Nov 7, 2016

@quinton-hoole @madhusudancs this is the second part of #34901. I think we can leave the third part (optimizing changeset application) to 1.6 unless we actually hit it in production...

@justinsb justinsb assigned ghost Nov 7, 2016
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Nov 7, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 22fe9853defc63e4b24b39a318d87f8d335e8736. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 39cd6cdc80fc8305136c44a90db50057607fd86d. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@justinsb
Federation: allow specification of dns zone by ID
df42806 
If we have a public & private zone with the same name (which is common
on AWS), this means we can still create records.  Also tighten up some
of the logic to allow for zones with duplicate names.
@justinsb
Copy link
Member Author

justinsb commented Nov 7, 2016

@quinton-hoole can we squeeze this in before feature-freeze :-) ?

@ghost
Copy link

ghost commented Nov 8, 2016

LGTM. Thanks @justinsb

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 8, 2016
@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Nov 8, 2016
@justinsb
Copy link
Member Author

Removing do-not-merge; I think it's the same bug where mergebot doesn't remove the release-note label once a release-note is applied.

@justinsb
Copy link
Member Author

Fix #33898

@justinsb justinsb added this to the v1.5 milestone Nov 16, 2016
@dims
Copy link
Member

dims commented Nov 16, 2016

hmm, there are two builds which succeeded but did not get marked as green

@dims
Copy link
Member

dims commented Nov 16, 2016

@k8s-bot test this [guess broken during the github outage this morning?]

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 47a431e into kubernetes:master Nov 17, 2016
@justinsb justinsb mentioned this pull request Nov 17, 2016
Closed
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinsb @k8s-ci-robot @dims @k8s-github-robot @googlebot