Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update deployment helper to return better error messages #36352

Merged
merged 1 commit into from
Dec 5, 2016
Merged

test: update deployment helper to return better error messages #36352

merged 1 commit into from
Dec 5, 2016

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Nov 7, 2016 •
edited by k8s-oncall
Loading

@kubernetes/deployment the problem with #36270 is that the selector key is never added in the deployment but this change would make it clearer.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Nov 7, 2016
@0xmichalis 0xmichalis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 7, 2016
@0xmichalis 0xmichalis assigned janetkuo and unassigned ixdy Nov 7, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this issue: #IGNORE

@mfojtik
Copy link
Contributor

mfojtik commented Nov 21, 2016

LGTM

@0xmichalis 0xmichalis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot test this issue: #IGNORE

@0xmichalis
Copy link
Contributor Author

@k8s-bot kops aws e2e test this issue: #32947

@0xmichalis
Copy link
Contributor Author

Anybody got any idea how can I restart Jenkins CRI GCE Node e2e?

@0xmichalis
Copy link
Contributor Author

@k8s-bot test this issue: #IGNORE

@k8s-github-robot
Copy link

@k8s-bot test this issue: #IGNORE

Tests have been pending for 24 hours

@0xmichalis 0xmichalis added the kind/flake Categorizes issue or PR as related to a flaky test. label Nov 29, 2016
@0xmichalis 0xmichalis added this to the v1.6 milestone Nov 29, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this

@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this #36351

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 2, 2016
@0xmichalis
Copy link
Contributor Author

@k8s-bot kops aws e2e test this #37974

@0xmichalis
Copy link
Contributor Author

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 886052c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis
Copy link
Contributor Author

@k8s-bot gce etcd3 e2e test this

@0xmichalis
Copy link
Contributor Author

@k8s-bot kops aws e2e test this #37974

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 886052c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis
Copy link
Contributor Author

@k8s-bot unit test this #32988

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 886052c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@0xmichalis
Copy link
Contributor Author

@k8s-bot kops aws e2e test this #37058

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 36352, 36538, 37976, 36374)

@k8s-github-robot k8s-github-robot merged commit 4fed326 into kubernetes:master Dec 5, 2016
@0xmichalis 0xmichalis deleted the fix-deployment-helper branch December 5, 2016 19:14
@0xmichalis 0xmichalis mentioned this pull request Dec 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@janetkuo janetkuo

Labels
area/test area/workload-api/deployment kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@0xmichalis @mfojtik @k8s-github-robot @k8s-ci-robot @rmmh @janetkuo @googlebot @ixdy