Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase master disk size in large clusters #36486

Merged
merged 1 commit into from
Nov 10, 2016
Merged

Increase master disk size in large clusters #36486

merged 1 commit into from
Nov 10, 2016

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 9, 2016 •
edited
Loading

Ref #34911

This change is Reviewable

@wojtek-t wojtek-t added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 9, 2016
@wojtek-t wojtek-t added this to the v1.5 milestone Nov 9, 2016
@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2016
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 9, 2016

@k8s-bot unit test this, issue: #36473

1 similar comment
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 9, 2016

@k8s-bot unit test this, issue: #36473

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 9, 2016

@k8s-bot unit test this, issue: #36473

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 3a3031f. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 9, 2016

@k8s-bot unit test this, issue: #36473

@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2016
@saad-ali
Copy link
Member

saad-ali commented Nov 9, 2016

Looks like this PR was LGTMed after code freeze for 1.5 was in effect. Is this a bug fix?

Removing milestone and adding do-not-merge until verification.

@saad-ali saad-ali removed this from the v1.5 milestone Nov 9, 2016
@saad-ali saad-ali added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 9, 2016
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 9, 2016

@saad-ali - this is bug fix for failing performance tests in 3000-node cluster.

@saad-ali
Copy link
Member

saad-ali commented Nov 9, 2016

@saad-ali - this is bug fix for failing performance tests in 3000-node cluster.

Ack. Approving bug fix for post-code freeze merge. Could you please reference the bug number in this PR.

@saad-ali saad-ali added this to the v1.5 milestone Nov 9, 2016
@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 9, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9813048 into kubernetes:master Nov 10, 2016
@wojtek-t wojtek-t deleted the increase_master_disk_size branch November 18, 2016 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wojtek-t @k8s-ci-robot @saad-ali @k8s-github-robot @gmarek @googlebot