Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling unit tests for verifying federation secret and namespace update #36563

Closed
wants to merge 1 commit into from
Closed

Disabling unit tests for verifying federation secret and namespace update #36563

wants to merge 1 commit into from

Conversation

nikhiljindal
Copy link
Contributor

@nikhiljindal nikhiljindal commented Nov 10, 2016 •
edited by k8s-oncall
Loading

Ref #36473 (comment)

Essentially #36536 part 2.

cc @mwielgus @saad-ali

This change is Reviewable

@nikhiljindal nikhiljindal added this to the v1.5 milestone Nov 10, 2016
@nikhiljindal nikhiljindal mentioned this pull request Nov 10, 2016
Closed
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Nov 10, 2016
@nikhiljindal nikhiljindal added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 10, 2016
@dims
Copy link
Member

dims commented Nov 10, 2016

LGTM 👍

@mwielgus
Copy link
Contributor

I have a fix for finalizer test failures. Do not merge yet.

@mwielgus mwielgus added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 10, 2016
@mwielgus
Copy link
Contributor

See: #36613

@dims
Copy link
Member

dims commented Nov 11, 2016

@mwielgus @nikhiljindal Do we abandon this PR? Or at least take off the v1.5 milestone

@mwielgus
Copy link
Contributor

It can be closed.

@mwielgus mwielgus closed this Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mwielgus mwielgus

Labels
area/test do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nikhiljindal @dims @mwielgus @googlebot @k8s-github-robot