Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change waiting time for a pod in e2e test #36777

Closed
wants to merge 1 commit into from
Closed

Change waiting time for a pod in e2e test #36777

wants to merge 1 commit into from

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Nov 14, 2016 •
edited

Change waiting time for a pod.

partially addresses: #36962

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 14, 2016
ixdy
ixdy reviewed Nov 14, 2016
View reviewed changes
test/e2e/kubectl.go
@@ -568,7 +568,7 @@ var _ = framework.KubeDescribe("Kubectl client", func() {
podJson := readTestFileOrDie(kubectlInPodFilename)
By("validating api verions")
framework.RunKubectlOrDieInput(string(podJson), "create", "-f", "-", nsFlag)
err := wait.PollImmediate(time.Second, time.Minute, func() (bool, error) {
err := wait.PollImmediate(3*time.Second, 3*time.Minute, func() (bool, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it really be taking more than a minute for this pod to start?

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 5b1c69e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2016
@mengqiy mengqiy changed the title Fix kubectl e2e test flake Add printing and retry logic for debugging kubectl e2e test flake Nov 15, 2016
@mengqiy
Copy link
Member Author

mengqiy commented Nov 15, 2016 •
edited

Updated the code. Added debugging code. Leave the waiting for pod code unchanged.

@mengqiy
Copy link
Member Author

mengqiy commented Nov 16, 2016

@ixdy ping

@mengqiy mengqiy mentioned this pull request Nov 16, 2016
Closed
@mengqiy mengqiy closed this Nov 16, 2016
@mengqiy mengqiy changed the title Add printing and retry logic for debugging kubectl e2e test flake Change waiting time for a pod in e2e test Nov 16, 2016
@mengqiy mengqiy reopened this Nov 16, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2016
@mengqiy
Copy link
Member Author

mengqiy commented Nov 16, 2016

Reopen this PR. Since we still need to give pod more time as other tests do.

cc: @dims

@dims
Copy link
Member

dims commented Nov 16, 2016

LGTM 👍 @ymqytw (pending tests, but hey 5 mins is better than one!)

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 0c5f10b16d922eb34d5c809266532eb67d473b23. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mengqiy
Copy link
Member Author

mengqiy commented Nov 16, 2016

@k8s-bot gce etcd3 e2e test this

@ixdy ixdy added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Nov 16, 2016
@ixdy
Copy link
Member

ixdy commented Nov 16, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2016
@ixdy
Copy link
Member

ixdy commented Nov 16, 2016

#36586 is 1.5, so I'm guessing this should be too?

@ixdy ixdy added this to the v1.5 milestone Nov 16, 2016
@ixdy
Copy link
Member

ixdy commented Nov 16, 2016

I'm happy that it looks like we found the actual bug, too. :)

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2016
@mengqiy
Copy link
Member Author

mengqiy commented Nov 17, 2016

@k8s-merge-robot Rebased.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2016
@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2016
@k8s-github-robot
Copy link

@ymqytw PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2016
@mengqiy
Copy link
Member Author

mengqiy commented Nov 17, 2016

Closing because this test is being reverted.

@mengqiy mengqiy closed this Nov 17, 2016
@saad-ali
Copy link
Member

This was a change to the common framework, does it not apply to other tests using this method?

@mengqiy mengqiy deleted the fix_kubectl_e2e_flake branch January 11, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixdy ixdy ixdy left review comments

Assignees

@ixdy ixdy

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengqiy @k8s-ci-robot @dims @ixdy @k8s-github-robot @saad-ali @googlebot