Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node E2E: Fix remote log fetching. #37338

Merged
merged 1 commit into from Nov 23, 2016
Merged

Node E2E: Fix remote log fetching. #37338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e_node/remote/remote.go
View file
Open in desktop
Expand Up @@ -299,7 +299,7 @@ func RunRemote(archive string, host string, cleanup bool, junitFilePrefix string
// journald nodes. We should have a more robust way to collect logs.
var (
logName = "system.log"
logPath = filepath.Join(workspace, logName)
logPath = fmt.Sprintf("/tmp/%s-%s", getTimestamp(), logName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if node is rebooted, the log will still be saved?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked offline, it will be saved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

destPath = fmt.Sprintf("%s/%s-%s", *resultsDir, host, logName)
)
glog.Infof("Test failed unexpectedly. Attempting to retreiving system logs (only works for nodes with journald)")
Expand Down