Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an else branch in trusty/configure-helper.sh #37388

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Fix an else branch in trusty/configure-helper.sh #37388

merged 1 commit into from
Nov 23, 2016

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented Nov 23, 2016 •
edited

Similar to #37358, for fixing #37257 on trusty.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2016
@yujuhong yujuhong added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 23, 2016
@yujuhong
Copy link
Contributor Author

/cc @davidopp @jszczepkowski

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 23, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit ffe1cac. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@yujuhong
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this.

@roberthbailey
Copy link
Contributor

Dupe of #37358 (sorry I didn't cc you on that PR).

@roberthbailey roberthbailey reopened this Nov 23, 2016
@roberthbailey
Copy link
Contributor

Sorry, just realized this was for the trusty code.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2016
@roberthbailey
Copy link
Contributor

/lgtm

@roberthbailey roberthbailey added this to the v1.5 milestone Nov 23, 2016
@roberthbailey roberthbailey added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 23, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit de03fad into kubernetes:master Nov 23, 2016
@yujuhong yujuhong deleted the fix_else branch March 13, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

@saad-ali saad-ali

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yujuhong @k8s-ci-robot @roberthbailey @k8s-github-robot @saad-ali