docs: devel: Add some notes about OWNERS process #37640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XS
|
cc @apelisse cc @michelleN (since doc move is in progress) |
thockin
reviewed
Nov 29, 2016
| @@ -9,6 +9,8 @@ will serve as the approvers for code to be submitted to these parts of the repos | |||
| are not necessarily expected to do the first code review for all commits to these areas, but they are | |||
| required to approve changes before they can be merged. | |||
|
|
|||
| **Note** The Kubernetes project has a hiatus on adding new approvers to OWNERS files. At this time we are [adding more reviewers](https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20%22Curating%20owners%3A%22%20) to take the load off of the current set of approvers and once we have had a chance to flush this out for a release we will begin adding new approvers once again. This is planned for the post Kubernetes 1.6.0 has been released | |||
There was a problem hiding this comment.
I hate nitpicking tiny PRs, but the last sentence here does not parse as English.
added 2 commits
November 29, 2016 13:13
Document that we are currently holding off on adding new approvers until the reviewers process is in place. And set a target deadline.
All of the tracking is happening here kubernetes-retired/contrib#1389 point people at it.
|
@Thocking fixed.
…On Tue, Nov 29, 2016 at 1:05 PM Tim Hockin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/devel/owners.md
<#37640 (review)>
:
> @@ -9,6 +9,8 @@ will serve as the approvers for code to be submitted to these parts of the repos
are not necessarily expected to do the first code review for all commits to these areas, but they are
required to approve changes before they can be merged.
+**Note** The Kubernetes project has a hiatus on adding new approvers to OWNERS files. At this time we are [adding more reviewers](https://github.com/kubernetes/kubernetes/pulls?utf8=%E2%9C%93&q=is%3Apr%20%22Curating%20owners%3A%22%20) to take the load off of the current set of approvers and once we have had a chance to flush this out for a release we will begin adding new approvers once again. This is planned for the post Kubernetes 1.6.0 has been released
I hate nitpicking tiny PRs, but the last sentence here does not parse as
English.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37640 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACDCEicqe94G1rAJD0sya9rceAbGweXks5rDJN7gaJpZM4K_UW->
.
|
thockin
added
release-note-none
|
lgtm |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
gah, the CLA label didn't get applied, I think. |
|
@foxish Does |
|
Yes it does. The submit queue knows to honor the human approved label.
…On Nov 29, 2016 5:58 PM, "Brian Grant" ***@***.***> wrote:
@foxish <https://github.com/foxish> Does cla: human-approved work for
CNCF CLA?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37640 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3U5352VviJvmZ4K_QLl5r6STEHThJHks5rDNhUgaJpZM4K_UW->
.
|
|
Can someone apply the label? CoreOS has a CLA for both Google and CNCF. |
|
Automatic merge from submit-queue |
|
@foxish ah, yes, you are right. |
thockin
added
the
cncf-cla: yes
|
Sorry! github's UI is too slow and clunky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: devel: point people at place for OWNERS status
All of the tracking is happening here
kubernetes-retired/contrib#1389 point people at it.
docs: devel: describe the current state of adding approvers
Document that we are currently holding off on adding new approvers until
the reviewers process is in place. And set a target deadline.
cc @calebamiles @bgrant0607 @apelisse