Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Modify GCI mounter to enable NFSv3" #37847

Merged
merged 1 commit into from Dec 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cluster/gce/gci/configure.sh
Expand Up @@ -100,10 +100,10 @@ function split-commas {

function install-gci-mounter-tools {
local -r rkt_version="v1.18.0"
local -r gci_mounter_version="v3"
local -r gci_mounter_version="v2"
local -r rkt_binary_sha1="75fc8f29c79bc9e505f3e7f6e8fadf2425c21967"
local -r rkt_stage1_fly_sha1="474df5a1f934960ba669b360ab713d0a54283091"
local -r gci_mounter_sha1="6ae71998bf9deba06468b036c2ba126626e0050d"
local -r gci_mounter_sha1="851e841d8640d6a05e64e22c493f5ac3c4cba561"
download-or-bust "${rkt_binary_sha1}" "https://storage.googleapis.com/kubernetes-release/rkt/${rkt_version}/rkt"
download-or-bust "${rkt_stage1_fly_sha1}" "https://storage.googleapis.com/kubernetes-release/rkt/${rkt_version}/stage1-fly.aci"
download-or-bust "${gci_mounter_sha1}" "https://storage.googleapis.com/kubernetes-release/gci-mounter/gci-mounter-${gci_mounter_version}.aci"
Expand Down
4 changes: 0 additions & 4 deletions cluster/gce/gci/mounter/Changelog
Expand Up @@ -5,7 +5,3 @@
## v2 (Fri Oct 28 2016 Vishnu Kannan <vishh@google.com>)
- Adding netbase package.
- Digest: sha256:c7dfe059fbbf976fc4284a87eb18adf0f8e0c4cf30a30f5a852842c772a64c2d

## v3 (Fri Nov 11 2016 Jing Xu <jinxu@google.com>)
- Add startmounter.sh script to start rpcbind before mounting for NFSv3
- Digest: sha256:35bc48a1ca97c3971611dc4662d08d131869daa692acb281c7e9e052924e38b1
4 changes: 2 additions & 2 deletions cluster/gce/gci/mounter/Dockerfile
Expand Up @@ -16,5 +16,5 @@ FROM ubuntu:xenial
MAINTAINER vishh@google.com

RUN apt-get update && apt-get install -y netbase nfs-common=1:1.2.8-9ubuntu12 glusterfs-client=3.7.6-1ubuntu1
ADD startmounter.sh /startmounter.sh
ENTRYPOINT ["/startmounter.sh"]

ENTRYPOINT ["/bin/mount"]
2 changes: 1 addition & 1 deletion cluster/gce/gci/mounter/Makefile
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

TAG=v3
TAG=v2
REGISTRY=gcr.io/google_containers
IMAGE=gci-mounter

Expand Down
20 changes: 6 additions & 14 deletions cluster/gce/gci/mounter/mounter
Expand Up @@ -18,7 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

MOUNTER_VERSION=v3
MOUNTER_VERSION=v2
MOUNTER_USER=root
ROOT_DIR=/home/kubernetes/bin
RKT_BINARY=${ROOT_DIR}/rkt
Expand Down Expand Up @@ -46,18 +46,10 @@ fi

echo "Running mount using a rkt fly container"

if [ "$#" -eq 0 ]; then
${RKT_BINARY} run --stage1-path=${STAGE1_ACI} \
--insecure-options=image \
--volume=kubelet,kind=host,source=/var/lib/kubelet,readOnly=false,recursive=true \
--mount volume=kubelet,target=/var/lib/kubelet \
${MOUNTER_IMAGE} --user=${MOUNTER_USER} --exec /bin/mount
else
${RKT_BINARY} run --stage1-path=${STAGE1_ACI} \
--insecure-options=image \
--volume=kubelet,kind=host,source=/var/lib/kubelet,readOnly=false,recursive=true \
--mount volume=kubelet,target=/var/lib/kubelet \
${MOUNTER_IMAGE} --user=${MOUNTER_USER} --exec /startmounter.sh -- "$@"
fi
${RKT_BINARY} run --stage1-path=${STAGE1_ACI} \
--insecure-options=image \
--volume=kubelet,kind=host,source=/var/lib/kubelet,readOnly=false,recursive=true \
--mount volume=kubelet,target=/var/lib/kubelet \
${MOUNTER_IMAGE} --user=${MOUNTER_USER} --exec /bin/mount -- "$@"

echo "Successfully ran mount using a rkt fly container"
26 changes: 0 additions & 26 deletions cluster/gce/gci/mounter/startmounter.sh

This file was deleted.

34 changes: 0 additions & 34 deletions test/e2e/common/volumes.go
Expand Up @@ -393,40 +393,6 @@ var _ = framework.KubeDescribe("GCP Volumes", func() {
})
})

////////////////////////////////////////////////////////////////////////
// NFSv3
////////////////////////////////////////////////////////////////////////

framework.KubeDescribe("NFSv3", func() {
It("should be mountable for NFSv3", func() {
config := VolumeTestConfig{
namespace: namespace.Name,
prefix: "nfs",
serverImage: "gcr.io/google_containers/volume-nfs:0.8",
serverPorts: []int{2049, 20048},
}

defer func() {
if clean {
volumeTestCleanup(f, config)
}
}()
pod := startVolumeServer(f, config)
serverIP := pod.Status.PodIP
framework.Logf("NFS server IP address: %v", serverIP)

volume := v1.VolumeSource{
NFS: &v1.NFSVolumeSource{
Server: serverIP,
Path: "/exports",
ReadOnly: true,
},
}
// Must match content of test/images/volumes-tester/nfs/index.html
testVolumeClient(f, config, volume, nil, "Hello from NFS!")
})
})

////////////////////////////////////////////////////////////////////////
// Gluster
////////////////////////////////////////////////////////////////////////
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_node/jenkins/gci-init.yaml
Expand Up @@ -8,5 +8,5 @@ runcmd:
- mount -B -o remount,exec /home/kubernetes/bin
- wget https://storage.googleapis.com/kubernetes-release/rkt/v1.18.0/rkt -O /home/kubernetes/bin/rkt
- wget https://storage.googleapis.com/kubernetes-release/rkt/v1.18.0/stage1-fly.aci -O /home/kubernetes/bin/stage1-fly.aci
- wget https://storage.googleapis.com/kubernetes-release/gci-mounter/gci-mounter-v3.aci -O /home/kubernetes/bin/gci-mounter-v3.aci
- wget https://storage.googleapis.com/kubernetes-release/gci-mounter/gci-mounter-v2.aci -O /home/kubernetes/bin/gci-mounter-v2.aci
- chmod a+x /home/kubernetes/bin/rkt