Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User reported issue: invalid argument "" for --etcd_quorum_read=: strconv.ParseBool: parsing "": invalid syntax #38290

Closed
justinsb opened this issue Dec 7, 2016 · 5 comments
Closed

User reported issue: invalid argument "" for --etcd_quorum_read=: strconv.ParseBool: parsing "": invalid syntax #38290

justinsb opened this issue Dec 7, 2016 · 5 comments

Comments

@justinsb
Copy link
Member

justinsb commented Dec 7, 2016

Slack user "nalin" reported an issue invalid argument "" for --etcd_quorum_read=: strconv.ParseBool: parsing "": invalid syntax

Looking at the code this makes sense. Will fix.
justinsb added a commit to justinsb/kubernetes that referenced this issue Dec 7, 2016
@justinsb
kube-up: Only specify ETCD_QUORUM_READ if non-empty
ca22a75 
Fix kubernetes#38290
@justinsb justinsb mentioned this issue Dec 7, 2016
Merged
@nalink nalink mentioned this issue Dec 7, 2016
Merged
@zmerlynn
Copy link
Member

For anyone following along, the fix for this bug unfortunately didn't get cherrypicked because of a process issue, and kube-up.sh is broken until 1.5.2.

cc @kubernetes/sig-aws

@zmerlynn zmerlynn mentioned this issue Dec 14, 2016
Closed
zmerlynn pushed a commit to zmerlynn/kubernetes that referenced this issue Dec 14, 2016
@justinsb @zmerlynn
kube-up: Only specify ETCD_QUORUM_READ if non-empty
30e1a04 
Fix kubernetes#38290
@sazo
Copy link

sazo commented Dec 26, 2016

I just added the new lines from zmerlynn@30e1a04

As a temperatur fix ONLY. If anyone like me dont want to wait. Worked like at charm for AWS cluster setup. :)

@oskarpearson
Copy link

A quick note, just as confirmation: the above temporary fix does resolve the issue for AWS - even though it's a change to a GCE-related file (cluster/gce/configure-vm.sh). It seems that the GCE files are used for certain aws functions.

@zmerlynn
Copy link
Member

zmerlynn commented Jan 3, 2017

In kube-up.sh based AWS deployment, the cluster/gce/configure-vm.sh script is shared between AWS and GCE.

@zmerlynn
Copy link
Member

zmerlynn commented Jan 3, 2017

Also, this fix was cherry-picked into the release-1.5 branch a while ago, so instead of manually adding the lines, you can also just checkout the release-1.5 branch and run from there.

@dwhitena dwhitena mentioned this issue Jan 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinsb @oskarpearson @sazo @zmerlynn