Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA e2e tests: fixed problem w/blocking channel. #38377

Merged
merged 1 commit into from
Dec 8, 2016
Merged

HPA e2e tests: fixed problem w/blocking channel. #38377

merged 1 commit into from
Dec 8, 2016

Conversation

jszczepkowski
Copy link
Contributor

HPA e2e tests: fixed problem w/blocking channel. Resolves #38298.

@jszczepkowski
HPA e2e tests: fixed problem w/blocking channel.
e94d2fd 
HPA e2e tests: fixed problem w/blocking channel. Resolves kubernetes#38298.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@jszczepkowski jszczepkowski added release-note-none Denotes a PR that doesn't merit a release note. cherrypick-candidate labels Dec 8, 2016
@jszczepkowski
Copy link
Contributor Author

CC @krousey @wojtek-t

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2016
@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2016
@wojtek-t wojtek-t mentioned this pull request Dec 8, 2016
Closed
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit e94d2fd. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit e94d2fd. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@krousey
Copy link
Contributor

krousey commented Dec 8, 2016

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit e94d2fd. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@rmmh
Copy link
Contributor

rmmh commented Dec 8, 2016

@k8s-bot cvm gce e2e test this
@k8s-bot gci gke e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38377, 36365, 36648, 37691, 38339)

@k8s-github-robot k8s-github-robot merged commit 126a842 into kubernetes:master Dec 8, 2016
@krousey krousey added this to the v1.5 milestone Dec 8, 2016
@saad-ali
Copy link
Member

saad-ali commented Dec 9, 2016

@jszczepkowski @krousey I am no longer doing batch cherry picks. If you want this in 1.5, please prepare a cherry-pick and assign it to me.

@jszczepkowski jszczepkowski mentioned this pull request Dec 9, 2016
Merged
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 9, 2016
k8s-github-robot pushed a commit that referenced this pull request Dec 9, 2016
Merge pull request #38454 from jszczepkowski/automated-cherry-pick-of…
b930bfd 
…-#38377-upstream-release-1.5

Automatic merge from submit-queue

cherry-pick of #38377: HPA e2e tests: fixed problem w/blocking channel.

Automated cherry-pick of #38377. HPA e2e tests: fixed problem w/blocking channel. Resolves #38298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piosz piosz piosz approved these changes

Assignees

@piosz piosz

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

HPA test can hang indefinitely
9 participants
@jszczepkowski @k8s-reviewable @k8s-cherrypick-bot @k8s-github-robot @k8s-ci-robot @krousey @rmmh @saad-ali @piosz