Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #34456 in release-1.4 #38385

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Cherry-pick #34456 in release-1.4 #38385

merged 1 commit into from
Dec 8, 2016

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Dec 8, 2016 •
edited

@janetkuo ptal

Cherry-pick of #34456 in 1.4

Should fix #33770

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Dec 8, 2016
@0xmichalis 0xmichalis added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 8, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@0xmichalis 0xmichalis added this to the v1.4 milestone Dec 8, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 8, 2016
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2016
@0xmichalis
Copy link
Contributor Author

@janetkuo does anybody else need to review this? @saad-ali ?

@saad-ali
Copy link
Member

saad-ali commented Dec 8, 2016

@janetkuo does anybody else need to review this? @saad-ali ?

1.4 branch == @jessfraz

@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 8, 2016
@jessfraz jessfraz merged commit 32d6857 into kubernetes:release-1.4 Dec 8, 2016
@0xmichalis 0xmichalis deleted the cherry-pick-34456-in-1.4 branch December 8, 2016 22:26
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@jessfraz jessfraz

@janetkuo janetkuo

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@0xmichalis @k8s-reviewable @k8s-github-robot @k8s-cherrypick-bot @saad-ali @janetkuo @jessfraz @k8s-ci-robot