Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove json serialization annotations from internal types #38406

Merged
merged 11 commits into from
Dec 10, 2016
Merged

Remove json serialization annotations from internal types #38406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d5afb71
Remove json serialization annotations from internal types
liggitt Dec 9, 2016
7119868
Remove generated codecs for internal types
liggitt Dec 8, 2016
fcf5bbc
Fix references from serializable types to use v1.ObjectMeta
liggitt Dec 8, 2016
3654d63
Compute apply patch using versioned object
liggitt Dec 9, 2016
6676bab
Fix unmarshaling into internal version of CustomMetricTargetList in v…
liggitt Dec 9, 2016
cc7a44f
Fix tests using internal types for serialization
liggitt Dec 9, 2016
12806be
Fix tests using internal types for generic printing
liggitt Dec 9, 2016
8b34e0e
Make --record compute patch using versioned object
liggitt Dec 9, 2016
d080246
Make thirdpartyresource encode objectmeta correctly
liggitt Dec 9, 2016
2d86844
Make sorting work on versioned objects
liggitt Dec 9, 2016
4536388
Update bazel
liggitt Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/apis/kubeadm/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,6 @@ type NodeConfiguration struct {
type ClusterInfo struct {
metav1.TypeMeta
// TODO(phase1+) this may become simply `api.Config`
CertificateAuthorities []string `json:"certificateAuthorities"`
Endpoints []string `json:"endpoints"`
CertificateAuthorities []string
Endpoints []string
}
3 changes: 0 additions & 3 deletions cmd/libs/go2idl/client-gen/test_apis/testgroup/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ go_library(
srcs = [
"doc.go",
"register.go",
"types.generated.go",
"types.go",
],
tags = ["automanaged"],
Expand All @@ -24,7 +23,5 @@ go_library(
"//pkg/apis/meta/v1:go_default_library",
"//pkg/runtime:go_default_library",
"//pkg/runtime/schema:go_default_library",
"//pkg/types:go_default_library",
"//vendor:github.com/ugorji/go/codec",
],
)