Renames kube-dns configure files from skydns* to kubedns* #38523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/L
thockin
added
release-note-none
thockin
reviewed
Dec 11, 2016
| @@ -41,15 +41,15 @@ function init { | |||
|
|
|||
| function deploy_dns { | |||
| echo "Deploying DNS on Kubernetes" | |||
| sed -e "s/\\\$DNS_DOMAIN/${DNS_DOMAIN}/g" "${KUBE_ROOT}/cluster/addons/dns/skydns-rc.yaml.sed" > skydns-rc.yaml | |||
There was a problem hiding this comment.
We should also fix the sed file to not use $DNS_DOMAIN but VAR_DNS_DOMAIN or __DNS_DOMAIN or something, so we don't have to double-escape like this...
thockin
added
the
lgtm
|
LGTM |
|
Automatic merge from submit-queue (batch tested with PRs 38058, 38523) |
|
This broke |
|
@deads2k I should be more careful. Thanks for fixing the scripts! |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 14, 2016
Automatic merge from submit-queue (batch tested with PRs 38727, 38726, 38347, 38348) Second pass of renaming kube-dns configure files Continue work of #38523. Not sure why cluster/centos/deployAddons.sh was omitted in previous PR. Also deletes the non-use `DNS_REPLICAS` var and changes `-rc` suffix in hack/local-up-cluster.sh. @thockin @bowei @deads2k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skydns-prefix and-rcsuffix are confusing and misleading. Renaming it tokubednsin existing yaml files and scripts.@bowei @thockin