Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed infinite loop in cluster validation. #38814

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Fixed infinite loop in cluster validation. #38814

merged 1 commit into from
Dec 16, 2016

Conversation

jszczepkowski
Copy link
Contributor

Fixed infinite loop in cluster validation when getting nodes failed.

@jszczepkowski jszczepkowski added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 9a37bf557020507dfa2344bf6fcacf7b012ce61c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

mwielgus
mwielgus reviewed Dec 15, 2016
View reviewed changes
cluster/validate-cluster.sh
@@ -91,7 +93,12 @@ while true; do
# Suppress errors from kubectl output because during cluster bootstrapping
# for clusters where the master node is registered, the apiserver will become
# available and then get restarted as the kubelet configures the docker bridge.
node=$(kubectl_retry get nodes) || continue
node=$(kubectl_retry get nodes) || if [[ "${attempt}" -gt "${MAX_ATTEMPTS}" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this simpler - for example don't mix assignment and if with exit and continue. Its hard to tell what this thing is exactly doing without good bash knowledge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some refactoring, but I'm not sure if it is much better.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 15, 2016
@jszczepkowski
Fixed infinite loop in cluster validation.
3dbfa94 
Fixed infinite loop in cluster validation when getting nodes failed.
@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 1eb9176 into kubernetes:master Dec 16, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@jszczepkowski jszczepkowski added this to the v1.5 milestone Dec 22, 2016
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 27, 2016
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this pull request Dec 28, 2016
@jszczepkowski
Merge branch 'release-1.5' into automated-cherry-pick-of-kubernetes#3…
e704315 
…8814-kubernetes#39079-release-1.5
@saad-ali
Copy link
Member

saad-ali commented Dec 28, 2016 •
edited

Cherry-picked to 1.5 in #39137

k8s-github-robot pushed a commit that referenced this pull request Dec 30, 2016
Merge pull request #39137 from jszczepkowski/automated-cherry-pick-of…
35159e4 
…-#38814-#39079-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38814 #39079 release 1.5

```release-note
fixed cluster validation script for HA clusters
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus left review comments

Assignees

@mwielgus mwielgus

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jszczepkowski @k8s-reviewable @k8s-ci-robot @mwielgus @k8s-github-robot @k8s-cherrypick-bot @saad-ali