-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make local-up-cluster.sh match "normal" launch without anonymous access #38898
make local-up-cluster.sh match "normal" launch without anonymous access #38898
Conversation
Jenkins GKE smoke e2e failed for commit 757e376. Full PR test history. The magic incantation to run this job again is |
Please update the original comment to add a release note indicating this fixes a break in local-up-cluster.sh #38847. Release note format:
|
Also can you verify that ./hack/local-up-cluster.sh starts without issue with this change? |
@k8s-bot cvm gke e2e test this |
Started fine for me. |
done. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
I think this fix cured the symptom--the script completes--but did not actually cure the problem. The apiserver produced rejects all connections from controller manager. |
Ref #38847
This changes the readiness detection, but keeps the defaults matching the "normal" launch without anonymous auth.
@janetkuo @saad-ali