Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path exist check in getPodVolumePathListFromDisk #38909

Merged
merged 1 commit into from Dec 28, 2016
Merged

Add path exist check in getPodVolumePathListFromDisk #38909

merged 1 commit into from Dec 28, 2016

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Dec 16, 2016 •
edited

Add the path exist check in the function. If the path does not exist,
return empty list and nil error.

fix issue #38498

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 16, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 02d054642b6b0e66f504aff510bdba5b58e0632e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali saad-ali self-assigned this Dec 16, 2016
@saad-ali saad-ali added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Dec 16, 2016
@saad-ali saad-ali added this to the v1.5 milestone Dec 16, 2016
@saad-ali
Copy link
Member

Thanks @jingxu97. LGTM

Please cherry-pick to 1.5 and 1.4 after merge.

@saad-ali
Copy link
Member

@k8s-bot bazel test this

@saad-ali
Copy link
Member

@k8s-bot verify test this

@saad-ali
Copy link
Member

@k8s-bot gci gke e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit 02d054642b6b0e66f504aff510bdba5b58e0632e. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 02d054642b6b0e66f504aff510bdba5b58e0632e. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali
Copy link
Member

Looks like you need to run update-bazel:

I1216 16:06:22.418] Verifying hack/make-rules/../../hack/verify-bazel.sh
W1216 16:06:26.564] 116d115
W1216 16:06:26.564] <         "//pkg/volume/util:go_default_library",
W1216 16:06:26.564] wrote BUILD for "/go/src/k8s.io/kubernetes/pkg/kubelet"
I1216 16:06:27.478] 
I1216 16:06:27.479] BUILD files are not up to date
I1216 16:06:27.479] Run ./hack/update-bazel.sh
I1216 16:06:27.480] FAILED   hack/make-rules/../../hack/verify-bazel.sh	5s

@jingxu97
Add path exist check in getPodVolumePathListFromDisk
3fbf68e 
Add the path exist check in the function. If the path does not exist,
return empty list and nil error.
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2016
@saad-ali
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 3fbf68e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38909, 39213)

@k8s-github-robot k8s-github-robot merged commit 17564ed into kubernetes:master Dec 28, 2016
@jingxu97 jingxu97 mentioned this pull request Jan 10, 2017
Merged
@jessfraz jessfraz added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 11, 2017
jessfraz added a commit that referenced this pull request Jan 11, 2017
@jessfraz
Merge pull request #39690 from jingxu97/automated-cherry-pick-of-#389…
a5e8b37 
…09-upstream-release-1.4

Automated cherry pick of #38909
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 20, 2017
@saad-ali saad-ali mentioned this pull request Jan 20, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 20, 2017
Merge pull request #40186 from saad-ali/automated-cherry-pick-of-#389…
c529006 
…09-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #38909 upstream release 1.5

Automated cherry pick PR #38909 ("Add path exist check in getPodVolumePathListFromDisk") to `release-1.5`
This was referenced Mar 10, 2017
Closed
Closed
gnufied added a commit to gnufied/origin that referenced this pull request Mar 28, 2017
@gnufied
UPSTREAM: <carry>: Fix logging when orphan pods are found in cleanupO…
f56239f 
…rphanedPodDirs

This is basically a cherry-pick of:

1. kubernetes/kubernetes#38909
2. https://github.com/kubernetes/kubernetes/pull/41626/files

But those commits can't be directly cherry picked because of whole
lot of dependencies.

Fixes openshift#13111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@dchen1107 dchen1107

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jingxu97 @k8s-reviewable @k8s-ci-robot @saad-ali @k8s-github-robot @jessfraz @dchen1107