Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #36169 #39750

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Automated cherry pick of #36169 #39750

merged 2 commits into from
Jan 12, 2017

Commits on Jan 11, 2017

  1. Bad conditional in vSphereLogin function 

    With this conditional being == instead of !=, a login would never actually be attempted by this provider, and disk attachments would fail.
    Robert Roland authored and Ritesh H Shukla committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    e57dea8 View commit details
    Browse the repository at this point in the history

  2. Applying changes per PR feedback - 

    Check for error conditions from the vSphere API and return the err if one occurs. The vSphere API does not return an err for unauthenticated users, it just returns a nil user object.
    Robert Roland authored and Ritesh H Shukla committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    fc1d0bb View commit details
    Browse the repository at this point in the history