Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #38338 #37413 #39757

Merged
merged 2 commits into from
Jan 20, 2017
Merged

Automated cherry pick of #38338 #37413 #39757

merged 2 commits into from
Jan 20, 2017

Conversation

kerneltime
Copy link

Cherry pick of #38338 #37413 on release-1.5.

#38338: Fix space in volumePath in vSphere
#37413: Fix for unmount volume to take in volumePath instead of

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Jan 11, 2017
@BaluDontu
Copy link
Contributor

@thockin : Can you approve this cherry pick request. This request has been on hold from past 6 days.

@thockin
Copy link
Member

thockin commented Jan 18, 2017

lgtm

@saad-ali who is cherry-czar for 1.5?

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 18, 2017
@kerneltime
Copy link
Author

@k8s-bot verify test this

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 6cbf073. Full PR test history. cc @kerneltime

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kerneltime
Copy link
Author

@k8s-bot verify test this

@mikedanese mikedanese added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jan 19, 2017
@spxtr
Copy link
Contributor

spxtr commented Jan 19, 2017

@k8s-bot test this
kubernetes/test-infra#1598

@saad-ali
Copy link
Member

@saad-ali who is cherry-czar for 1.5?

Still me :\

@saad-ali saad-ali added this to the v1.5 milestone Jan 19, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f4aca2d into kubernetes:release-1.5 Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@kerneltime @k8s-reviewable @BaluDontu @thockin @k8s-ci-robot @spxtr @saad-ali @k8s-github-robot @mikedanese