Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete *-munge-docs.sh deprecation. #39832

Merged
merged 1 commit into from
Jan 30, 2017

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon commented Jan 12, 2017

What this PR does / why we need it:
Complete *-munge-docs.sh deprecation.
TOC generation now handled by kubernetes/release#247

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
ref #38309

Special notes for your reviewer:

cc @bgrant0607 @thockin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 12, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jan 12, 2017
@bgrant0607
Copy link
Member

Thanks!

/lgtm

@k8s-ci-robot
Copy link
Contributor

@bgrant0607: you can't LGTM a PR unless you are an assignee.

In response to this comment:

Thanks!

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bgrant0607 bgrant0607 added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 13, 2017
@bgrant0607
Copy link
Member

@k8s-bot gci gce e2e test this

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @jbeda
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@david-mcmahon david-mcmahon added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2017
@bgrant0607 bgrant0607 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@david-mcmahon: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e 902ffd5 link @k8s-bot kops aws e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 39832, 40660)

@k8s-github-robot k8s-github-robot merged commit da60dc2 into kubernetes:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants