Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressing issue #39427 adding a flag --output to 'kubectl version' #39858

Merged
merged 1 commit into from
Mar 28, 2017
Merged

addressing issue #39427 adding a flag --output to 'kubectl version' #39858

merged 1 commit into from
Mar 28, 2017
+209 −16

Commits on Mar 28, 2017

  1. addressing issue kubernetes#39427 adding a flag --output to allow for… 

    … either json or yaml.

updating with PR changes requested.

latest changes to having short for human readable only, and error cases moved a bit to the end.

rebase fixes

latest pr. changes.

small change moving return nil out of switch.

updated the nil check for the error in the humanreadable case.

more optimization in humanreadable code.

pushed up current test changes, this is purely temporary

finished writing tests

updated test and function names.

changed output extensions from .sh to output.

updated version, version struct now just called Version and not VersionObj.

made a few changes to testing.

fixed testing issues, created better test and cleanup

go format change.
    @alejandroEsc
    alejandroEsc committed Mar 28, 2017
    Configuration menu
    Copy the full SHA
    a5e6dcb View commit details
    Browse the repository at this point in the history