New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Statefulset instead in e2e and controller #39939
Conversation
Rename e2e folder to statefulset
kindly ping @mikedanese, could you please give this a quick review? This is easy to become |
@@ -22,15 +22,15 @@ package app | |||
|
|||
import ( | |||
"k8s.io/apimachinery/pkg/runtime/schema" | |||
petset "k8s.io/kubernetes/pkg/controller/petset" | |||
statefulset "k8s.io/kubernetes/pkg/controller/statefulset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this import is named?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emm ... seems not
Jenkins kops AWS e2e failed for commit a88cbdc. Full PR test history. cc @resouer The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot kops aws e2e test this |
/lgtm |
Automatic merge from submit-queue (batch tested with PRs 34763, 38706, 39939, 40020) |
Quick fix ref: #35534
We should finish the issue to meet v1.6 milestone.