Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets min kube-dns replica number to 2 #40281

Closed
wants to merge 1 commit into from

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jan 22, 2017

From #40063.

Setting the min value to 2 in dns-horizontal-autoscaler to mitigate kube-dns single point failure. The downside is we will have 2 replicas even if there is only 1 node, though this is still a better setup.

@thockin @bowei

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jan 22, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 03efda4. Full PR test history.

cc @MrHohn, your PR dashboard

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 03efda4. Full PR test history.

cc @MrHohn, your PR dashboard

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 03efda4. Full PR test history.

cc @MrHohn, your PR dashboard

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thockin
Copy link
Member

thockin commented Jan 23, 2017

We don't really want a min of 2 - on a 1 node cluster that will run DNS twice. We used to have different configs for node count and CPU count - did we eliminate that? That was what let us have a bi-modal config - a ladder for nodes and a scaler for cores.

@MrHohn
Copy link
Member Author

MrHohn commented Jan 23, 2017

I see your point now. But sadly current autoscaler is unable to support that --- it either use linear mode for both nodes and cores or use ladder mode for both.

@thockin
Copy link
Member

thockin commented Jan 23, 2017 via email

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @bowei
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn
Copy link
Member Author

MrHohn commented Jan 24, 2017

Close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants