-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets min kube-dns replica number to 2 #40281
Conversation
Jenkins GCI GKE smoke e2e failed for commit 03efda4. Full PR test history. The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Jenkins GKE smoke e2e failed for commit 03efda4. Full PR test history. The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Jenkins Kubemark GCE e2e failed for commit 03efda4. Full PR test history. The magic incantation to run this job again is Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We don't really want a min of 2 - on a 1 node cluster that will run DNS twice. We used to have different configs for node count and CPU count - did we eliminate that? That was what let us have a bi-modal config - a ladder for nodes and a scaler for cores. |
I see your point now. But sadly current autoscaler is unable to support that --- it either use linear mode for both nodes and cores or use ladder mode for both. |
Open to suggestions to get the right semantics... I feel like we had this
correct before.
…On Sun, Jan 22, 2017 at 6:47 PM, Zihong Zheng ***@***.***> wrote:
I see your point now. But sadly current autoscaler is unable to support
that --- it either use linear mode for both nodes and cores or use ladder
mode for both.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40281 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVME2qqnIG3bp0eGHp9J5hEZnoiOkks5rVBS0gaJpZM4LqiOs>
.
|
[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
Close it for now. |
From #40063.
Setting the
min
value to 2 in dns-horizontal-autoscaler to mitigatekube-dns
single point failure. The downside is we will have 2 replicas even if there is only 1 node, though this is still a better setup.@thockin @bowei