[Federation][kubefed] Create a dedicated service account for federation controller manager in the host cluster and give it appropriate permissions. #40392
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -254,3 +254,74 @@ func (r *ClusterRoleBindingBuilder) Binding() (ClusterRoleBinding, error) { | |
|
|
||
| return r.ClusterRoleBinding, nil | ||
| } | ||
|
|
||
| // +k8s:deepcopy-gen=false | ||
|
There was a problem hiding this comment. I'm not a huge fan of having helpers in the internal types api packages. @deads2k I guess you're not making it worse, so I'm not asking for you to solve this problem. There was a problem hiding this comment.
RBAC really demonstrates the issue with using external versions. The RBAC authorizer doesn't care which version of the API you use, but you run into crazy problems with caches, informers, conversions, and helpers if you don't use the internal types. I suspect that if you saw the code duplication involved in having v1beta1 and v1alpha1 support, you'd be displeased. |
||
| // RoleBindingBuilder let's us attach methods. It is similar to | ||
| // ClusterRoleBindingBuilder above. | ||
| type RoleBindingBuilder struct { | ||
| RoleBinding RoleBinding | ||
| } | ||
|
|
||
| // NewRoleBinding creates a RoleBinding builder that can be used | ||
| // to define the subjects of a role binding. At least one of | ||
| // the `Groups`, `Users` or `SAs` method must be called before | ||
| // calling the `Binding*` methods. | ||
| func NewRoleBinding(roleName, namespace string) *RoleBindingBuilder { | ||
|
There was a problem hiding this comment. Document that at least one of the functions below must be called. |
||
| return &RoleBindingBuilder{ | ||
| RoleBinding: RoleBinding{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: roleName, | ||
| Namespace: namespace, | ||
| }, | ||
| RoleRef: RoleRef{ | ||
| APIGroup: GroupName, | ||
| Kind: "Role", | ||
| Name: roleName, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| // Groups adds the specified groups as the subjects of the RoleBinding. | ||
| func (r *RoleBindingBuilder) Groups(groups ...string) *RoleBindingBuilder { | ||
|
There was a problem hiding this comment. Public methods should have a godoc string. |
||
| for _, group := range groups { | ||
| r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, Subject{Kind: GroupKind, Name: group}) | ||
| } | ||
| return r | ||
| } | ||
|
|
||
| // Users adds the specified users as the subjects of the RoleBinding. | ||
| func (r *RoleBindingBuilder) Users(users ...string) *RoleBindingBuilder { | ||
| for _, user := range users { | ||
| r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, Subject{Kind: UserKind, Name: user}) | ||
| } | ||
| return r | ||
| } | ||
|
|
||
| // SAs adds the specified service accounts as the subjects of the | ||
| // RoleBinding. | ||
| func (r *RoleBindingBuilder) SAs(namespace string, serviceAccountNames ...string) *RoleBindingBuilder { | ||
| for _, saName := range serviceAccountNames { | ||
| r.RoleBinding.Subjects = append(r.RoleBinding.Subjects, Subject{Kind: ServiceAccountKind, Namespace: namespace, Name: saName}) | ||
| } | ||
| return r | ||
| } | ||
|
|
||
| // BindingOrDie calls the binding method and panics if there is an error. | ||
| func (r *RoleBindingBuilder) BindingOrDie() RoleBinding { | ||
| ret, err := r.Binding() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| return ret | ||
| } | ||
|
|
||
| // Binding builds and returns the RoleBinding API object from the builder | ||
| // object. | ||
| func (r *RoleBindingBuilder) Binding() (RoleBinding, error) { | ||
| if len(r.RoleBinding.Subjects) == 0 { | ||
| return RoleBinding{}, fmt.Errorf("subjects are required: %#v", r.RoleBinding) | ||
| } | ||
|
|
||
| return r.RoleBinding, nil | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont we need similar constant for federation controller manager to talk to host cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the service account below.