Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genericapiserver: cut off more dependencies – episode 6 #40822

Merged
merged 4 commits into from
Feb 2, 2017
Merged

genericapiserver: cut off more dependencies – episode 6 #40822

merged 4 commits into from
Feb 2, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Feb 1, 2017

Follow-up of #40808

approved based on #40363

@sttts sttts added area/apiserver kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 1, 2017
@sttts sttts added this to the 1.6 milestone Feb 1, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Feb 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: sttts

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sttts sttts added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 1, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@deads2k
Copy link
Contributor

deads2k commented Feb 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2017
@sttts sttts added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2017
@sttts sttts added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 2, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2017
@sttts sttts mentioned this pull request Feb 2, 2017
Merged
@sttts sttts added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 2, 2017
@sttts sttts added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 2, 2017
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2017
@sttts
Copy link
Contributor Author

sttts commented Feb 2, 2017

@k8s-bot unit test this

@sttts
Copy link
Contributor Author

sttts commented Feb 2, 2017

@k8s-bot unit test this issue #36351

@deads2k
Copy link
Contributor

deads2k commented Feb 2, 2017

@k8s-bot unit test this

@sttts
Copy link
Contributor Author

sttts commented Feb 2, 2017

@k8s-bot cri e2e test this

@k8s-ci-robot
Copy link
Contributor

@sttts: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins CRI GCE e2e 3811384 link @k8s-bot cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4a4678a into kubernetes:master Feb 2, 2017
@sttts sttts deleted the sttts-more-cutoffs-6 branch February 2, 2017 13:27
k8s-github-robot pushed a commit that referenced this pull request Feb 2, 2017
Merge pull request #40853 from sttts/sttts-more-cutoffs-7
62c9cb4 
Automatic merge from submit-queue (batch tested with PRs 35782, 35831, 39279, 40853, 40867)

genericapiserver: cut off more dependencies – episode 7

Follow-up of #40822

approved based on #40363
@calebamiles calebamiles modified the milestones: v1.6, 1.6 Feb 13, 2017
akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request Sep 20, 2022
@k8s-publishing-bot
Merge pull request #40853 from sttts/sttts-more-cutoffs-7
1141425 
Automatic merge from submit-queue (batch tested with PRs 35782, 35831, 39279, 40853, 40867)

genericapiserver: cut off more dependencies – episode 7

Follow-up of kubernetes/kubernetes#40822

approved based on #40363

Kubernetes-commit: 62c9cb4684d09e0d6533e8ad281b2b994441d77e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @k8s-github-robot @k8s-reviewable @deads2k @k8s-ci-robot @calebamiles