kubeadm: added tests cert/pkiutil pkg #40888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/M
|
@mikedanese mind reviewing this PR? |
pires
suggested changes
Feb 6, 2017
| if err != nil { | ||
| t.Fatalf("Couldn't create tmpdir") | ||
| } | ||
| defer os.Remove(tmpdir) |
| if err != nil { | ||
| t.Fatalf("Couldn't create tmpdir") | ||
| } | ||
| defer os.Remove(tmpdir) |
k8s-github-robot
added
size/L
|
I let @pires lgtm this once he's happy with it /approve |
k8s-github-robot
added
the
approved
|
@pires can I get your lgtm for this? |
|
@dmmcquay please squash. |
raised coverage from ~37% to ~77%
dmmcquay
force-pushed
the
kubeadm_pkiutil_tests
branch
from
c5ff0f2
to
d23507f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: dmmcquay, luxas Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@k8s-bot cvm gce e2e test this |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Automatic merge from submit-queue (batch tested with PRs 41061, 40888, 40664, 41020, 41085) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raised coverage from ~37% to ~77%
What this PR does / why we need it: added tests to cert/pkiutil pkg and raised coverage from ~37% to ~77%
Adding unit tests is a WIP from #34136
Special notes for your reviewer: /cc @luxas @pires
Release note: