-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: added tests cert/pkiutil pkg #40888
kubeadm: added tests cert/pkiutil pkg #40888
Conversation
@mikedanese mind reviewing this PR? |
if err != nil { | ||
t.Fatalf("Couldn't create tmpdir") | ||
} | ||
defer os.Remove(tmpdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use os.RemoveAll
.
if err != nil { | ||
t.Fatalf("Couldn't create tmpdir") | ||
} | ||
defer os.Remove(tmpdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use os.RemoveAll
.
I let @pires lgtm this once he's happy with it /approve |
@pires can I get your lgtm for this? |
@dmmcquay please squash. |
raised coverage from ~37% to ~77%
c5ff0f2
to
d23507f
Compare
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: dmmcquay, luxas Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot cvm gce e2e test this |
/lgtm |
Automatic merge from submit-queue (batch tested with PRs 41061, 40888, 40664, 41020, 41085) |
raised coverage from ~37% to ~77%
What this PR does / why we need it: added tests to cert/pkiutil pkg and raised coverage from ~37% to ~77%
Adding unit tests is a WIP from #34136
Special notes for your reviewer: /cc @luxas @pires
Release note: