Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #40892 #41219

Commits on Feb 9, 2017

  1. Fixes kubernetes#40819

    Start looking up the virtual machine by it's UUID in vSphere again. Looking up by IP address is problematic and can either not return a VM entirely, or could return the wrong VM.
    
    Retrieves the VM's UUID in one of two methods - either by a `vm-uuid` entry in the cloud config file on the VM, or via sysfs. The sysfs route requires root access, but restores the previous functionality.
    
    Multiple VMs in a vCenter cluster can share an IP address - for example, if you have multiple VM networks, but they're all isolated and use the same address range. Additionally, flannel network address ranges can overlap.
    
    vSphere seems to have a limitation of reporting no more than 16 interfaces from a virtual machine, so it's possible that the IP address list on a VM is completely untrustworthy anyhow - it can either be empty (because the 16 interfaces it found were veth interfaces with no IP address), or it can report the flannel IP.
    Robert Roland authored and Ritesh H Shukla committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    fd5c08b View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2017

  1. :Addressing code review feedback

    Robert Roland authored and Ritesh H Shukla committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    cf00ca6 View commit details
    Browse the repository at this point in the history