Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #40030 #41232

Merged
merged 1 commit into from Feb 10, 2017
Merged

Automated cherry pick of #40030 #41232

merged 1 commit into from Feb 10, 2017

Conversation

colemickens
Copy link
Contributor

Cherry pick of #40030 on release-1.5.

#40030: azure disk: restrict length of name

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: colemickens

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2017
@colemickens
Copy link
Contributor Author

Ping @saad-ali for cherry-pick approval.

@saad-ali saad-ali self-assigned this Feb 10, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Feb 10, 2017
@saad-ali saad-ali added this to the v1.5 milestone Feb 10, 2017
@colemickens
Copy link
Contributor Author

@k8s-bot kops aws e2e test this
@k8s-bot cri e2e test this
@k8s-bot verify test this

@colemickens
Copy link
Contributor Author

@k8s-bot cri e2e test this

@k8s-ci-robot
Copy link
Contributor

@colemickens: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins CRI GCE e2e 52d1a71 link @k8s-bot cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@colemickens
Copy link
Contributor Author

@k8s-bot cri e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8d72a3e into kubernetes:release-1.5 Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@colemickens @k8s-reviewable @k8s-github-robot @k8s-ci-robot @thockin @saad-ali