Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default attach_detach_controller reconciler sync period to 1 minute #41363

Merged
merged 1 commit into from
Feb 14, 2017
Merged

Change default attach_detach_controller reconciler sync period to 1 minute #41363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/kube-controller-manager/app/options/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func NewCMServer() *CMServer {
ConcurrentGCSyncs: 20,
ClusterSigningCertFile: "/etc/kubernetes/ca/ca.pem",
ClusterSigningKeyFile: "/etc/kubernetes/ca/ca.key",
ReconcilerSyncLoopPeriod: metav1.Duration{Duration: 5 * time.Second},
ReconcilerSyncLoopPeriod: metav1.Duration{Duration: 60 * time.Second},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default 5 second also has a problem that - polling an entire cluster one by one (like how we do currently) is going to take more than 5 seconds even if done parallely, so likely we have overlapping polls going on.

EnableTaintManager: true,
},
}
Expand Down