Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only construct shortcutmapper when we have the discovery client #41570

Merged
merged 1 commit into from
Feb 17, 2017
Merged

only construct shortcutmapper when we have the discovery client #41570

merged 1 commit into from
Feb 17, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 16, 2017

Resource shortnames come from the discoveryclient, so we should only wrap with that mapper when we have the information we need.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 16, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Feb 16, 2017

@kubernetes/sig-cli-pr-reviews

@deads2k
Copy link
Contributor Author

deads2k commented Feb 16, 2017

@fabianofranz @Kargakis this fixes --local again.

@dims
Copy link
Member

dims commented Feb 16, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: deads2k, dims

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Feb 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 16, 2017
@dims
Copy link
Member

dims commented Feb 16, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 16, 2017
@dims
Copy link
Member

dims commented Feb 16, 2017

hmm, how do i get the bot to drop do-not-merge label..

@deads2k deads2k removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f0b58a7 into kubernetes:master Feb 17, 2017
@deads2k deads2k deleted the cli-03-tolerate-missing-shortcut branch March 7, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @k8s-reviewable @dims @k8s-github-robot @k8s-ci-robot