Removes additional columns in test_owners.csv #41660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-github-robot
added
size/XL
|
Sorry for breaking the bot! **cc: @ethernetdan, @pwittrock, @kubernetes/test-infra-reviewers ** |
|
This change is |
k8s-github-robot
added
needs-rebase
calebamiles
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
looks like it also adds about 200 lines... that intentional? |
ethernetdan
reviewed
Feb 20, 2017
test/test_owners.csv
Outdated
| HA-master survive addition/removal replicas different zones,derekwaynecarr,0,api-machinery | ||
| HA-master survive addition/removal replicas multizone workers,rkouj,0,api-machinery | ||
| HA-master survive addition/removal replicas same zone,derekwaynecarr,0,api-machinery | ||
| AppArmor should enforce an AppArmor profile,derekwaynecarr,0,node |
There was a problem hiding this comment.
@calebamiles Looks like the file got repeated here. Could it be an issue with the hack/update_owners.py script?
- sorts all e2e tests (with sort (GNU coreutils) 8.25) - moves all k8s.io/* tests to the end - removes duplicated tests (with uniq (GNU coreutils) 8.25)
k8s-github-robot
removed
the
lgtm
|
|
Related to kubernetes/test-infra#1935 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: calebamiles, spxtr Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fixes a huge collection of typos with the number of columns in the CSV file that probably has broken the auto assign bot
Special notes for your reviewer:
None
Release note:
NONE