New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist kubemark in node_ssh_supported_providers for log dump #41800
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: shyamjvs, wojtek-t Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
By the way, the original PR broke the log collection for all builds. We no longer collect any logs.
Bumping the priority of this fix. |
/cc @k8s-oncall |
Merging this PR manually to fix broken log dumping for tests. |
@shyamjvs, I think it's good to loop the oncall in, and let them do the merge if possible :-) |
Sure. I'll take care of this in future. :) |
Seems like PR #41739 did not truly enable hollow node logging, as there were a couple of issues:
node_ssh_supported_providers
if [[ "${KUBERNETES_PROVIDER}" -eq "kubemark" && "${ENABLE_HOLLOW_NODE_LOGS:-}" -eq "true" ]];
in bash didn't work as I expected. Fixed it now and checked.With these changes, it should work now.
cc @kubernetes/sig-scalability-misc @wojtek-t @gmarek