Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist kubemark in node_ssh_supported_providers for log dump #41800

Merged
merged 1 commit into from Feb 21, 2017

Conversation

shyamjvs
Copy link
Member

Seems like PR #41739 did not truly enable hollow node logging, as there were a couple of issues:

  • kubemark is not whitelisted as a k8s provider for which we can perform node SSH (because that's the case with hollow nodes), but we can still SSH to real nodes. So added it to node_ssh_supported_providers
  • The if [[ "${KUBERNETES_PROVIDER}" -eq "kubemark" && "${ENABLE_HOLLOW_NODE_LOGS:-}" -eq "true" ]]; in bash didn't work as I expected. Fixed it now and checked.

With these changes, it should work now.

cc @kubernetes/sig-scalability-misc @wojtek-t @gmarek

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@shyamjvs shyamjvs added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 21, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2017
@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: shyamjvs, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2017
@yujuhong
Copy link
Contributor

By the way, the original PR broke the log collection for all builds. We no longer collect any logs.

I0221 04:18:09.992] Dumping master and node logs to /workspace/_artifacts
I0221 04:18:09.992] /workspace/kubernetes/cluster/log-dump.sh: line 132: gce: unbound variable
I0221 04:18:09.993] /workspace/kubernetes/cluster/log-dump.sh: line 132: gce: unbound variable
I0221 04:18:09.993] /workspace/kubernetes/cluster/log-dump.sh: line 132: gce: unbound variable
I0221 04:18:09.993] /workspace/kubernetes/cluster/log-dump.sh: line 132: gce: unbound variable
I0221 04:18:09.993] /workspace/kubernetes/cluster/log-dump.sh: line 132: gce: unbound variable

Bumping the priority of this fix.

@yujuhong
Copy link
Contributor

/cc @k8s-oncall

@shyamjvs
Copy link
Member Author

@yujuhong Thanks for bringing this up. This PR should also fix that issue. It was a problem in this line where I used '-eq' comparator instead of '==' for strings.

@shyamjvs
Copy link
Member Author

Merging this PR manually to fix broken log dumping for tests.

@shyamjvs shyamjvs merged commit 746cc5d into kubernetes:master Feb 21, 2017
@shyamjvs shyamjvs deleted the fix-hollow-node-logging branch February 21, 2017 18:13
@yujuhong
Copy link
Contributor

@shyamjvs, I think it's good to loop the oncall in, and let them do the merge if possible :-)

@shyamjvs
Copy link
Member Author

Sure. I'll take care of this in future. :)
In this case, I thought that fixing the logs is crucial to debugging test failures that might happen in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants