Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing --use-kubernetes-version to --kubernetes-version for kubeadm beta #41820

Merged
merged 1 commit into from
Feb 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/kubeadm/app/cmd/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func NewCmdInit(out io.Writer) *cobra.Command {
`Use alternative domain for services, e.g. "myorg.internal"`,
)
cmd.PersistentFlags().StringVar(
&cfg.KubernetesVersion, "use-kubernetes-version", cfg.KubernetesVersion,
&cfg.KubernetesVersion, "kubernetes-version", cfg.KubernetesVersion,
`Choose a specific Kubernetes version for the control plane`,
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/kubeadm/test/cmd/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func TestCmdInitKubernetesVersion(t *testing.T) {
args string
expected bool
}{
{"--use-kubernetes-version=foobar", false},
{"--kubernetes-version=foobar", false},
}

for _, rt := range initTest {
Expand Down
3 changes: 3 additions & 0 deletions hack/verify-flags/exceptions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ federation/deploy/config.json.sample: "cluster_cidr": "10.188.0.0/14",
federation/deploy/config.json.sample: "cluster_name": "cluster1-kubernetes",
federation/deploy/config.json.sample: "cluster_name": "cluster2-kubernetes",
federation/deploy/config.json.sample: "cluster_name": "cluster3-kubernetes",
federation/deploy/config.json.sample: "kubernetes_version": "v1.4.0"
federation/deploy/config.json.sample: "kubernetes_version": "v1.4.0"
federation/deploy/config.json.sample: "kubernetes_version": "v1.4.0"
federation/deploy/config.json.sample: "num_nodes": 3,
federation/deploy/config.json.sample: "num_nodes": 3,
federation/deploy/config.json.sample: "num_nodes": 3,
Expand Down
47 changes: 24 additions & 23 deletions hack/verify-flags/known-flags.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,16 @@ api-external-dns-names
api-port
api-prefix
api-rate
api-server-port
api-servers
api-server-advertise-address
api-server-port
api-server-service-type
api-servers
api-token
api-version
apiserver-arg-overrides
apiserver-count
apiserver-count
attach-detach-reconcile-sync-period
audit-log-maxage
audit-log-maxbackup
audit-log-maxsize
Expand Down Expand Up @@ -96,8 +97,8 @@ concurrent-gc-syncs
concurrent-namespace-syncs
concurrent-replicaset-syncs
concurrent-resource-quota-syncs
concurrent-serviceaccount-token-syncs
concurrent-service-syncs
concurrent-serviceaccount-token-syncs
config-map
config-map-namespace
config-sync-period
Expand All @@ -110,13 +111,13 @@ conntrack-tcp-timeout-established
consumer-port
consumer-service-name
consumer-service-namespace
contain-pod-resources
container-port
container-runtime
container-runtime-endpoint
contain-pod-resources
contention-profiling
controllermanager-arg-overrides
controller-start-interval
controllermanager-arg-overrides
core-kubeconfig
cors-allowed-origins
cpu-cfs-quota
Expand All @@ -139,6 +140,7 @@ deployment-controller-sync-period
deployment-label-key
deserialization-cache-size
dest-file
disable-attach-detach-reconcile-sync
disable-filter
disable-kubenet
disable-log-dump
Expand All @@ -162,8 +164,6 @@ dump-logs-on-failure
duration-sec
e2e-output-dir
e2e-verify-service-account
etcd-metrics-scrape-uri
etcd-version-scrape-uri
enable-controller-attach-detach
enable-cri
enable-custom-metrics
Expand All @@ -181,14 +181,16 @@ etcd-cafile
etcd-certfile
etcd-config
etcd-keyfile
etcd-metrics-scrape-uri
etcd-mutation-timeout
etcd-persistent-storage
etcd-prefix
etcd-pv-capacity
etcd-persistent-storage
etcd-quorum-read
etcd-server
etcd-servers
etcd-servers-overrides
etcd-version-scrape-uri
event-burst
event-qps
event-ttl
Expand All @@ -207,13 +209,15 @@ experimental-allowed-unsafe-sysctls
experimental-bootstrap-kubeconfig
experimental-bootstrap-token-auth
experimental-keystone-url
experimental-check-node-capabilities-before-mount
experimental-cri
experimental-fail-swap-on
experimental-kernel-memcg-notification
experimental-keystone-ca-file
experimental-keystone-url
experimental-mounter-path
experimental-nvidia-gpus
experimental-prefix
experimental-cri
experimental-check-node-capabilities-before-mount
experimental-kernel-memcg-notification
external-etcd-cafile
external-etcd-certfile
external-etcd-endpoints
Expand All @@ -222,7 +226,6 @@ external-hostname
external-ip
external-name
extra-peer-dirs
experimental-fail-swap-on
failover-timeout
failure-domains
fake-clientset
Expand All @@ -245,6 +248,7 @@ from-literal
func-dest
fuzz-iters
garbage-collector-enabled
garbage-collector-enabled
gather-logs-sizes
gather-metrics-at-teardown
gather-resource-usage
Expand Down Expand Up @@ -333,8 +337,8 @@ kube-master
kube-master
kube-master-url
kube-reserved
kubeadm-path
kubeadm-cmd-skip
kubeadm-path
kubecfg-file
kubectl-path
kubelet-address
Expand Down Expand Up @@ -363,6 +367,7 @@ kubernetes-anywhere-path
kubernetes-anywhere-phase2-provider
kubernetes-anywhere-up-timeout
kubernetes-service-node-port
kubernetes-version
label-columns
large-cluster-size-threshold
last-release-pr
Expand All @@ -378,6 +383,7 @@ listers-package
load-balancer-ip
lock-file
log-flush-frequency
log-lines-total
long-running-request-regexp
low-diskspace-threshold-mb
make-iptables-util-chains
Expand Down Expand Up @@ -540,6 +546,7 @@ rkt-stage1-image
root-ca-file
root-dir
route-reconciliation-period
run-duration
run-kubelet-mode
run-proxy
run-services-mode
Expand Down Expand Up @@ -589,8 +596,8 @@ skip-unsafe
sort-by
source-file
ssh-env
ssh-keyfile
ssh-key
ssh-keyfile
ssh-options
ssh-user
start-services
Expand All @@ -617,8 +624,8 @@ test-timeout
tls-ca-file
tls-cert-file
tls-private-key-file
to-version
tls-sni-cert-key
to-version
token-auth-file
ttl-keys-prefix
ttl-secs
Expand All @@ -630,14 +637,14 @@ unix-socket
update-period
upgrade-image
upgrade-target
use-service-account-credentials
use-kubernetes-cluster-service
use-kubernetes-version
use-service-account-credentials
user-whitelist
verb
verify-only
versioned-clientset-package
viper-config
viper-config
volume-dir
volume-plugin-dir
volume-stats-agg-period
Expand All @@ -649,9 +656,3 @@ windows-line-endings
www-prefix
zone-id
zone-name
garbage-collector-enabled
viper-config
log-lines-total
run-duration
attach-detach-reconcile-sync-period
disable-attach-detach-reconcile-sync