New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump GCI to gci-stable-56-9000-84-2 on release-1.5 #41828
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: freehan Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
cluster/kubemark/config-default.sh
Outdated
@@ -32,9 +32,9 @@ MASTER_ROOT_DISK_SIZE=${KUBEMARK_MASTER_ROOT_DISK_SIZE:-10GB} | |||
REGISTER_MASTER_KUBELET=${REGISTER_MASTER:-false} | |||
PREEMPTIBLE_NODE=${PREEMPTIBLE_NODE:-false} | |||
|
|||
MASTER_OS_DISTRIBUTION=${KUBE_MASTER_OS_DISTRIBUTION:-debian} | |||
MASTER_OS_DISTRIBUTION=${KUBE_MASTER_OS_DISTRIBUTION:-gci} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that kubemark in 1.5 branch is not using gci image as master. Not sure what is the reason behind it. I change it to match the config of master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm and cc/ @saad-ali the release czar |
+@mwielgus the new 1.5 release branch manager: This is worth keeping a close eye on. After the previous GCI image update, a bunch of 1.5 CI broke. |
adding labels based on #41828 (comment) |
@k8s-bot kubemark e2e test this |
1 similar comment
@k8s-bot kubemark e2e test this |
Looks like kubemark in 1.5 is not compatible with GCI image. Will switch back to use CVM for master
|
@k8s-bot test this |
Automatic merge from submit-queue |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Manual cherry-pick of #41819