kube-apiserver: improve bootstrap token authentication error messages #41985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
ericchiang
commented
Feb 23, 2017
| // | ||
| func tokenErrorf(s *api.Secret, format string, i ...interface{}) { | ||
| format = fmt.Sprintf("Bootstrap secret %s/%s matching bearer token ", s.Namespace, s.Name) + format | ||
| glog.V(3).Infof(format, i...) |
There was a problem hiding this comment.
Don't know if this is the correct verbosity level. It was the existing one taken from isSecretExpired.
|
@k8s-bot kops aws e2e test this |
k8s-github-robot
added
the
needs-rebase
ericchiang
force-pushed
the
bootstrap-token-auth-logging
branch
from
9bc8e47
to
ba31bf7
Compare
k8s-github-robot
removed
the
needs-rebase
|
ping @ericchiang @jbeda @liggitt |
ericchiang
force-pushed
the
bootstrap-token-auth-logging
branch
from
ba31bf7
to
f5fa115
Compare
|
rebased for good measure. Anyone want to approve? |
|
@k8s-bot gce etcd3 e2e test this |
|
/release-note-none |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ericchiang
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Thanks @deads2k! |
|
Automatic merge from submit-queue (batch tested with PRs 41530, 44814, 43620, 41985) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested by @jbeda as a follow up to #41281.
cc @jbeda @luxas @kubernetes/sig-auth-pr-reviews