federation: Fixing runtime-config support for federation-apiserver #42225
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package app | ||
|
|
||
| import ( | ||
| "github.com/golang/glog" | ||
|
|
||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "k8s.io/apiserver/pkg/registry/rest" | ||
| "k8s.io/apiserver/pkg/server/storage" | ||
| ) | ||
|
|
||
| // Function to get a map of resources and the corresponding storages. | ||
| type getResourcesStorageFunc func() map[string]rest.Storage | ||
|
|
||
| // Filters the resources from the given resources storage map to those that are enabled in the given apiResourceConfigSource. | ||
| // resourcesStorageMap is expected to contain all resources in a group version. | ||
| // Returns false if none of the resources are enabled and hence the whole group version should be disabled. | ||
|
There was a problem hiding this comment. the bool is equivalent to There was a problem hiding this comment. Isnt it better to keep that logic in this function rather than requiring all callers to do that? There was a problem hiding this comment. You have a point, this was meant to keep the other code clean. I am fine with it. |
||
| func enabledResources(groupVersion schema.GroupVersion, resourcesStorageMap map[string]getResourcesStorageFunc, apiResourceConfigSource storage.APIResourceConfigSource) (bool, map[string]rest.Storage) { | ||
| enabledResources := map[string]rest.Storage{} | ||
| groupName := groupVersion.Group | ||
| if !apiResourceConfigSource.AnyResourcesForGroupEnabled(groupName) { | ||
| glog.V(1).Infof("Skipping disabled API group %q", groupName) | ||
| return false, enabledResources | ||
| } | ||
| for resource, fn := range resourcesStorageMap { | ||
| if apiResourceConfigSource.ResourceEnabled(groupVersion.WithResource(resource)) { | ||
| resources := fn() | ||
| for k, v := range resources { | ||
| enabledResources[k] = v | ||
| } | ||
| } else { | ||
| glog.V(1).Infof("Skipping disabled resource %s in API group %q", resource, groupName) | ||
| } | ||
| } | ||
| if len(enabledResources) == 0 { | ||
| glog.V(1).Infof("Skipping API group %q since there is no enabled resource", groupName) | ||
| return false, enabledResources | ||
| } | ||
| return true, enabledResources | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these having any side effects? Or why are they a func and not just vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no side effect. same as above