Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volumes: Add logging when removing node fails #42249

Merged
merged 1 commit into from
Jun 22, 2017
Merged

volumes: Add logging when removing node fails #42249

merged 1 commit into from
Jun 22, 2017

Conversation

justinsb
Copy link
Member

Part of #40583

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2017
@justinsb justinsb mentioned this pull request Feb 28, 2017
Closed
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 28, 2017
@justinsb justinsb modified the milestone: v1.6 Feb 28, 2017
@calebamiles
Copy link
Contributor

not quite a bug @ethernetdan, but a simple improvement to logging.

cc: @kubernetes/kubernetes-release-managers

@k8s-reviewable
Copy link

This change is Reviewable

@justinsb justinsb removed the kind/bug Categorizes issue or PR as related to a bug. label Mar 2, 2017
@jingxu97
Copy link
Contributor

jingxu97 commented Mar 7, 2017

/approve

1 similar comment
@jingxu97
Copy link
Contributor

jingxu97 commented Mar 7, 2017

/approve

@jingxu97
Copy link
Contributor

jingxu97 commented Mar 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2017
@ethernetdan ethernetdan added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement labels Mar 7, 2017
@enisoc enisoc modified the milestones: v1.6.1, v1.6 Mar 23, 2017
@enisoc
Copy link
Member

enisoc commented Mar 23, 2017

I'm cleaning out the milestone since we're coming up on the cut. This doesn't seem to be a release-blocker.

@justinsb
Copy link
Member Author

@k8s-bot unit test this
@k8s-bot node e2e test this
@k8s-bot non-cri node e2e test this

@justinsb
Copy link
Member Author

@saad-ali can you approve please

/assign @saad-ali

(I think I need a macro... although it should probably just be auto-assigned when there's only one approver anyway!)

@justinsb
Copy link
Member Author

@k8s-bot non-cri node e2e test this

@justinsb
Copy link
Member Author

@k8s-bot bazel test this

@justinsb
Copy link
Member Author

@k8s-bot non-cri node e2e test this
@k8s-bot gce etcd3 e2e test this

@thockin thockin removed this from the v1.6.1 milestone May 27, 2017
@justinsb
Copy link
Member Author

justinsb commented Jun 1, 2017

@k8s-bot non-cri node e2e test this
@k8s-bot gce etcd3 e2e test this
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@justinsb justinsb added this to the v1.7 milestone Jun 1, 2017
@justinsb
Copy link
Member Author

justinsb commented Jun 1, 2017

@k8s-bot non-cri node e2e test this

@justinsb
Copy link
Member Author

justinsb commented Jun 1, 2017

@k8s-bot non-cri node e2e test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@marun marun added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 8, 2017
@justinsb
Copy link
Member Author

@k8s-bot non-cri node e2e test this

@justinsb
Copy link
Member Author

/retest

1 similar comment
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/retest

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/remove-priority P3
/priority awaiting-more-evidence
I'm not actually sure this is the right priority, just trying to remove the old priority/PN labels

@k8s-ci-robot k8s-ci-robot added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed priority/P3 labels Jun 16, 2017
@marun
Copy link
Contributor

marun commented Jun 20, 2017

@k8s-bot non-cri node e2e test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2017 •
edited

@justinsb: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins non-CRI GCE Node e2e b7edfda link @k8s-bot non-cri node e2e test this
Jenkins GCE etcd3 e2e b7edfda link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dchen1107
Copy link
Member

/retest

@msau42
Copy link
Member

msau42 commented Jun 21, 2017

@k8s-bot non-cri node e2e test this

@msau42
Copy link
Member

msau42 commented Jun 21, 2017

/lgtm

@dchen1107
Copy link
Member

/retest

@dchen1107
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, jingxu97, justinsb, msau42

Associated issue: 40583

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42252, 42251, 42249, 47512, 47887)

k8s-github-robot pushed a commit that referenced this pull request Jun 22, 2017
Merge pull request #42249 from justinsb/volumes_logging
d0a2beb 
Automatic merge from submit-queue (batch tested with PRs 42252, 42251, 42249, 47512, 47887)

volumes: Add logging when removing node fails

Part of #40583

```release-note
NONE
```
@k8s-github-robot k8s-github-robot merged commit d0a2beb into kubernetes:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

@saad-ali saad-ali

@jingxu97 jingxu97

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet