Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DaemonSet should auto update pod location when add/remove taint to node #42398

Closed
mdshuai opened this issue Mar 2, 2017 · 5 comments
Closed

DaemonSet should auto update pod location when add/remove taint to node #42398

mdshuai opened this issue Mar 2, 2017 · 5 comments
Assignees
@lukaszo
Labels
area/workload-api/daemonset kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.6

Comments

@mdshuai
Copy link

mdshuai commented Mar 2, 2017

Kubernetes version (use kubectl version):
v1.7.0-alpha.0.661+01bfbb5fa04621-dirty

How to reproduce it (as minimally and precisely as possible):

1. Add taint to node
[root@dhcp-140-98 dma]# kubectl taint node mynode role=master:NoSchedule
node "mynode" tainted
[root@dhcp-140-98 dma]# kc describe no mynode|grep -i taints
Taints:			role=master:NoSchedule

2. Create ds and check ds status
[root@dhcp-140-98 dma]# kubectl create -f https://raw.githubusercontent.com/mdshuai/testfile-openshift/master/daemonset/daemonset.yaml
daemonset "hello-daemonset" created
[root@dhcp-140-98 dma]# kubectl get ds
NAME              DESIRED   CURRENT   READY     NODE-SELECTOR   AGE
hello-daemonset   0         0         0         <none>          5s

3. Remove the taint from node
[root@dhcp-140-98 dma]# kubectl taint node mynode role:NoSchedule-
node "mynode" tainted

4. Check ds status again
[root@dhcp-140-98 dma]# kubectl get ds
NAME              DESIRED   CURRENT   READY     NODE-SELECTOR   AGE
hello-daemonset   0         0         0         <none>          3m
[root@dhcp-140-98 kubernetes]# oc get ds
NAME              DESIRED   CURRENT   READY     NODE-SELECTOR   AGE
hello-daemonset   0         0         0         <none>          9m

What you expected to happen:

  1. ds should add pod to the node after remove the taint from node.

Anything else we need to know:
@mdshuai
Copy link
Author

mdshuai commented Mar 2, 2017 •
edited

@derekwaynecarr @aveshagarwal help check, thanks

@lukaszo
Copy link
Contributor

lukaszo commented Mar 2, 2017

@mdshuai how long have you waited? DaemonSet should sync eventually.

@mdshuai
Copy link
Author

mdshuai commented Mar 2, 2017

@lukaszo more than 5mins

@lukaszo
Copy link
Contributor

lukaszo commented Mar 2, 2017

Ok, I know what's the problem. Fix is on the way

@lukaszo lukaszo mentioned this issue Mar 2, 2017
Merged
@lukaszo
Copy link
Contributor

lukaszo commented Mar 2, 2017

/assign

@0xmichalis 0xmichalis added kind/bug Categorizes issue or PR as related to a bug. area/workload-api/daemonset sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 2, 2017
@0xmichalis 0xmichalis added this to the v1.6 milestone Mar 2, 2017
k8s-github-robot pushed a commit that referenced this issue Mar 4, 2017
Merge pull request #42414 from lukaszo/ds-taint
204ffda 
Automatic merge from submit-queue (batch tested with PRs 42456, 42457, 42414, 42480, 42370)

Enque DaemonSet sync when node taints changed

Fixes #42398

 @Kargakis @janetkuo @mdshuai PTAL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaszo lukaszo

Labels
area/workload-api/daemonset kind/bug Categorizes issue or PR as related to a bug. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
3 participants
@lukaszo @0xmichalis @mdshuai