Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the system:authenticated group adder smarter #42491

Merged
merged 1 commit into from
Mar 6, 2017
Merged

make the system:authenticated group adder smarter #42491

merged 1 commit into from
Mar 6, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 3, 2017

Fixes #42437

This prevents the group adder from adding the system:authenticated group when:

  1. it's already in the list
  2. the user is system:anonymous
  3. system:unauthenticated is in the list

Smaller alternative to #42421 for 1.6.

@kubernetes/sig-auth-pr-reviews @enj @liggitt

@deads2k deads2k added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@liggitt liggitt added this to the v1.6 milestone Mar 3, 2017
@liggitt liggitt added area/security sig/auth Categorizes an issue or PR as relevant to SIG Auth. labels Mar 3, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Mar 3, 2017
@enj
Copy link
Member

enj commented Mar 3, 2017

LGTM

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 3, 2017 •
edited

@deads2k: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCI GKE smoke e2e 379a73a link @k8s-bot gci gke e2e test this
Jenkins GKE smoke e2e 379a73a link @k8s-bot cvm gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 3, 2017

@k8s-bot cvm gce e2e test this

@liggitt
Copy link
Member

liggitt commented Mar 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: deads2k, liggitt

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 3, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Mar 3, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Mar 6, 2017

approval issue is on vendor/BUILD, tagging.

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 61e7d1e into kubernetes:master Mar 6, 2017
@deads2k deads2k deleted the auth-03-adder branch March 7, 2017 20:06
@enj enj mentioned this pull request May 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deads2k @k8s-reviewable @enj @k8s-ci-robot @liggitt @k8s-github-robot